Message ID | 20211010180228.16137-1-cam@neo-zeon.de (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | ALSA: hda/realtek: Fix for quirk to enable speaker output on the Lenovo 13s Gen2. | expand |
On Sun, 10 Oct 2021 20:02:30 +0200, Cameron Berkenpas wrote: > > The previous patch's HDA verb initialization for the Lenovo 13s sequence was > slightly off. This updated verb sequence has been tested and confirmed working. You forgot your Signed-off-by line. Please resubmit with it. Also, at the next submission, please add the BugLink tag to the relevant bugzilla URL, as well as Fixes tag pointing to the commit to be corrected, too. And, put Cc to stable in the patch (not need to actually send to stable but add a line Cc: <stable@vger.kernel.org> in the patch description around your sign-off). Last but not lease, please Cc to me at the next patch submission (actually send to me). thanks, Takashi
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 4407f7da57c4..84d3e062a335 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8344,7 +8344,7 @@ static const struct hda_fixup alc269_fixups[] = { .v.verbs = (const struct hda_verb[]) { { 0x20, AC_VERB_SET_COEF_INDEX, 0x24 }, { 0x20, AC_VERB_SET_PROC_COEF, 0x41 }, - { 0x20, AC_VERB_SET_PROC_COEF, 0xb020 }, + { 0x20, AC_VERB_SET_COEF_INDEX, 0x26 }, { 0x20, AC_VERB_SET_PROC_COEF, 0x2 }, { 0x20, AC_VERB_SET_PROC_COEF, 0x0 }, { 0x20, AC_VERB_SET_PROC_COEF, 0x0 },