diff mbox series

[13/13] ASoC: amd: enable yc machine driver build

Message ID 20211011055621.13240-14-Vijendar.Mukunda@amd.com (mailing list archive)
State Superseded
Headers show
Series Add Yellow Carp platform ASoC driver | expand

Commit Message

Vijendar Mukunda Oct. 11, 2021, 5:56 a.m. UTC
Enable YC platform dmic machine driver build.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
 sound/soc/amd/Kconfig     | 7 +++++++
 sound/soc/amd/yc/Makefile | 2 ++
 2 files changed, 9 insertions(+)

Comments

Randy Dunlap Oct. 11, 2021, 7:55 a.m. UTC | #1
On 10/10/21 10:56 PM, Vijendar Mukunda wrote:
> Enable YC platform dmic machine driver build.
> 
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
>   sound/soc/amd/Kconfig     | 7 +++++++
>   sound/soc/amd/yc/Makefile | 2 ++
>   2 files changed, 9 insertions(+)
> 
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index 42825e8ad2ad..864d80f14421 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -67,3 +67,10 @@ config SND_SOC_AMD_ACP6x
>   	depends on X86 && PCI
>   	help
>   	 This option enables ACP v6.x DMIC support on AMD platform
> +

For the help text above here and the one below:

a. End the sentence with a period ('.').

b. Pay attention to the documented/accepted kernel style:

(from Documentation/process/coding-style.rst, section 10):

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.

> +config SND_SOC_AMD_YC_MACH
> +        tristate "AMD YC support for DMIC"
> +        select SND_SOC_DMIC
> +        depends on SND_SOC_AMD_ACP6x
> +        help
> +         This option enables machine driver for DMIC endpoint


thanks.
Vijendar Mukunda Oct. 11, 2021, 8:25 a.m. UTC | #2
On 10/11/21 1:25 PM, Randy Dunlap wrote:
> On 10/10/21 10:56 PM, Vijendar Mukunda wrote:
>> Enable YC platform dmic machine driver build.
>>
>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>> ---
>>   sound/soc/amd/Kconfig     | 7 +++++++
>>   sound/soc/amd/yc/Makefile | 2 ++
>>   2 files changed, 9 insertions(+)
>>
>> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
>> index 42825e8ad2ad..864d80f14421 100644
>> --- a/sound/soc/amd/Kconfig
>> +++ b/sound/soc/amd/Kconfig
>> @@ -67,3 +67,10 @@ config SND_SOC_AMD_ACP6x
>>       depends on X86 && PCI
>>       help
>>        This option enables ACP v6.x DMIC support on AMD platform
>> +
> 
> For the help text above here and the one below:
> 
> a. End the sentence with a period ('.').
> 
> b. Pay attention to the documented/accepted kernel style:
> 
> (from Documentation/process/coding-style.rst, section 10):
> 
> For all of the Kconfig* configuration files throughout the source tree,
> the indentation is somewhat different.  Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.
> 
Will fix it and post the new version.

>> +config SND_SOC_AMD_YC_MACH
>> +        tristate "AMD YC support for DMIC"
>> +        select SND_SOC_DMIC
>> +        depends on SND_SOC_AMD_ACP6x
>> +        help
>> +         This option enables machine driver for DMIC endpoint
> 
> 
> thanks.
diff mbox series

Patch

diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index 42825e8ad2ad..864d80f14421 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -67,3 +67,10 @@  config SND_SOC_AMD_ACP6x
 	depends on X86 && PCI
 	help
 	 This option enables ACP v6.x DMIC support on AMD platform
+
+config SND_SOC_AMD_YC_MACH
+        tristate "AMD YC support for DMIC"
+        select SND_SOC_DMIC
+        depends on SND_SOC_AMD_ACP6x
+        help
+         This option enables machine driver for DMIC endpoint
diff --git a/sound/soc/amd/yc/Makefile b/sound/soc/amd/yc/Makefile
index 20f8dfe6abb4..dc2974440388 100644
--- a/sound/soc/amd/yc/Makefile
+++ b/sound/soc/amd/yc/Makefile
@@ -2,6 +2,8 @@ 
 # Yellow Carp platform Support
 snd-pci-acp6x-objs	:= pci-acp6x.o
 snd-acp6x-pdm-dma-objs	:= acp6x-pdm-dma.o
+snd-soc-acp6x-mach-objs := acp6x-mach.o
 
 obj-$(CONFIG_SND_SOC_AMD_ACP6x) += snd-pci-acp6x.o
 obj-$(CONFIG_SND_SOC_AMD_ACP6x) += snd-acp6x-pdm-dma.o
+obj-$(CONFIG_SND_SOC_AMD_YC_MACH)   += snd-soc-acp6x-mach.o