diff mbox series

[1/6] ASoC: core: Remove invalid snd_soc_component_set_jack call

Message ID 20211015161257.27052-2-cezary.rojewski@intel.com (mailing list archive)
State Accepted
Commit 7db53c21b1c3c25676d1125049bc92c756421cd6
Headers show
Series ASoC: Sanity checks and soc-topology updates | expand

Commit Message

Cezary Rojewski Oct. 15, 2021, 4:12 p.m. UTC 
From: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>

If snd_soc_component_set_jack() is called after
snd_soc_component_remove() it may operate on memory which is freed in
->remove handler.

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
 sound/soc/soc-core.c | 3 ---
 1 file changed, 3 deletions(-)
diff mbox series

Patch

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 121a12244f08..7eaa8fc81d31 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1363,9 +1363,6 @@  static void soc_remove_component(struct snd_soc_component *component,
 	if (probed)
 		snd_soc_component_remove(component);
 
-	/* For framework level robustness */
-	snd_soc_component_set_jack(component, NULL, NULL);
-
 	list_del_init(&component->card_list);
 	snd_soc_dapm_free(snd_soc_component_get_dapm(component));
 	soc_cleanup_component_debugfs(component);