| Message ID | 20211017160028.23318-1-christianshewitt@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bc387887ae22d6ed6439e83968b5be3443a8e57d |
| Headers | show |
| Series | ASoC: meson: implement driver_name for snd_soc_card in meson-card-utils | expand |
On Sun 17 Oct 2021 at 16:00, Christian Hewitt <christianshewitt@gmail.com> wrote: > Implement driver_name to provide an alternative to card_name for userspace > configuration of Amlogic audio cards. > > Suggested-by: Matthias Reichl <hias@horus.com> > Signed-off-by: Christian Hewitt <christianshewitt@gmail.com> > --- > The meson AIU/AXG drivers currently require alsa confs based on the board > model name which is unique to each board. This is very flexible for audio > use-cases, but not very maintainable for distros with a single use-case > that need to support a large number of different Amlogic boards. Using a > driver name to match the card conf instead of card/model name reduces the > number of confs needed in the LibreELEC (Kodi) distro from 41 to 2. > > sound/soc/meson/meson-card-utils.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/meson/meson-card-utils.c b/sound/soc/meson/meson-card-utils.c > index 415cc0046e4b..29b0174f4b5c 100644 > --- a/sound/soc/meson/meson-card-utils.c > +++ b/sound/soc/meson/meson-card-utils.c > @@ -302,6 +302,7 @@ int meson_card_probe(struct platform_device *pdev) > > priv->card.owner = THIS_MODULE; > priv->card.dev = dev; > + priv->card.driver_name = dev->driver->name; > priv->match_data = data; I was preparing something similar to help with alsa-ucm so Acked-by: Jerome Brunet <jbrunet@baylibre.com> > > ret = snd_soc_of_parse_card_name(&priv->card, "model");
On Sun, 17 Oct 2021 16:00:28 +0000, Christian Hewitt wrote: > Implement driver_name to provide an alternative to card_name for userspace > configuration of Amlogic audio cards. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: meson: implement driver_name for snd_soc_card in meson-card-utils commit: bc387887ae22d6ed6439e83968b5be3443a8e57d All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/meson/meson-card-utils.c b/sound/soc/meson/meson-card-utils.c index 415cc0046e4b..29b0174f4b5c 100644 --- a/sound/soc/meson/meson-card-utils.c +++ b/sound/soc/meson/meson-card-utils.c @@ -302,6 +302,7 @@ int meson_card_probe(struct platform_device *pdev) priv->card.owner = THIS_MODULE; priv->card.dev = dev; + priv->card.driver_name = dev->driver->name; priv->match_data = data; ret = snd_soc_of_parse_card_name(&priv->card, "model");
Implement driver_name to provide an alternative to card_name for userspace configuration of Amlogic audio cards. Suggested-by: Matthias Reichl <hias@horus.com> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com> --- The meson AIU/AXG drivers currently require alsa confs based on the board model name which is unique to each board. This is very flexible for audio use-cases, but not very maintainable for distros with a single use-case that need to support a large number of different Amlogic boards. Using a driver name to match the card conf instead of card/model name reduces the number of confs needed in the LibreELEC (Kodi) distro from 41 to 2. sound/soc/meson/meson-card-utils.c | 1 + 1 file changed, 1 insertion(+)