diff mbox series

ALSA: intel-dsp-config: add quirk for JSL devices based on ES8336 codec

Message ID 20211027023254.24955-1-yung-chuan.liao@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series ALSA: intel-dsp-config: add quirk for JSL devices based on ES8336 codec | expand

Commit Message

Bard Liao Oct. 27, 2021, 2:32 a.m. UTC
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

These devices are based on an I2C/I2S device, we need to force the use
of the SOF driver otherwise the legacy HDaudio driver will be loaded -
only HDMI will be supported.

We previously added support for other Intel platforms but missed
JasperLake.

BugLink: https://github.com/thesofproject/linux/issues/3210
Fixes: 9d36ceab9415 ('ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec')
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
 sound/hda/intel-dsp-config.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Takashi Iwai Oct. 27, 2021, 6:22 a.m. UTC | #1
On Wed, 27 Oct 2021 04:32:54 +0200,
Bard Liao wrote:
> 
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> 
> These devices are based on an I2C/I2S device, we need to force the use
> of the SOF driver otherwise the legacy HDaudio driver will be loaded -
> only HDMI will be supported.
> 
> We previously added support for other Intel platforms but missed
> JasperLake.
> 
> BugLink: https://github.com/thesofproject/linux/issues/3210
> Fixes: 9d36ceab9415 ('ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec')
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Reviewed-by: Kai Vehmanen <kai.vehmanen@intel.com>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>

As the commit still didn't reach to me but only in Mark's tree,
it should go through asoc tree.

Acked-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi
Pierre-Louis Bossart Nov. 19, 2021, 11:48 p.m. UTC | #2
On 10/27/21 1:22 AM, Takashi Iwai wrote:
> On Wed, 27 Oct 2021 04:32:54 +0200,
> Bard Liao wrote:
>>
>> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>>
>> These devices are based on an I2C/I2S device, we need to force the use
>> of the SOF driver otherwise the legacy HDaudio driver will be loaded -
>> only HDMI will be supported.
>>
>> We previously added support for other Intel platforms but missed
>> JasperLake.
>>
>> BugLink: https://github.com/thesofproject/linux/issues/3210
>> Fixes: 9d36ceab9415 ('ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec')
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> Reviewed-by: Kai Vehmanen <kai.vehmanen@intel.com>
>> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> 
> As the commit still didn't reach to me but only in Mark's tree,
> it should go through asoc tree.
> 
> Acked-by: Takashi Iwai <tiwai@suse.de>

Looks like this patch was missed, likely a merge window effect?

Takashi, you should be able to apply this on your tree now? or do you
want me to resend it?

Thanks
-Pierre
Takashi Iwai Nov. 20, 2021, 7:23 a.m. UTC | #3
On Sat, 20 Nov 2021 00:48:10 +0100,
Pierre-Louis Bossart wrote:
> 
> 
> 
> On 10/27/21 1:22 AM, Takashi Iwai wrote:
> > On Wed, 27 Oct 2021 04:32:54 +0200,
> > Bard Liao wrote:
> >>
> >> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> >>
> >> These devices are based on an I2C/I2S device, we need to force the use
> >> of the SOF driver otherwise the legacy HDaudio driver will be loaded -
> >> only HDMI will be supported.
> >>
> >> We previously added support for other Intel platforms but missed
> >> JasperLake.
> >>
> >> BugLink: https://github.com/thesofproject/linux/issues/3210
> >> Fixes: 9d36ceab9415 ('ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec')
> >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> >> Reviewed-by: Kai Vehmanen <kai.vehmanen@intel.com>
> >> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> > 
> > As the commit still didn't reach to me but only in Mark's tree,
> > it should go through asoc tree.
> > 
> > Acked-by: Takashi Iwai <tiwai@suse.de>
> 
> Looks like this patch was missed, likely a merge window effect?
> 
> Takashi, you should be able to apply this on your tree now? or do you
> want me to resend it?

I merged it now.  Thanks!


Takashi
diff mbox series

Patch

diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c
index b9ac9e9e45a4..10a0bffc3cf6 100644
--- a/sound/hda/intel-dsp-config.c
+++ b/sound/hda/intel-dsp-config.c
@@ -299,6 +299,15 @@  static const struct config_entry config_table[] = {
 	},
 #endif
 
+/* JasperLake */
+#if IS_ENABLED(CONFIG_SND_SOC_SOF_JASPERLAKE)
+	{
+		.flags = FLAG_SOF,
+		.device = 0x4dc8,
+		.codec_hid = "ESSX8336",
+	},
+#endif
+
 /* Tigerlake */
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_TIGERLAKE)
 	{