ASoC: SOF: Remove pm_runtime_put_autosuspend() for SOF OF device

Commit Message

Daniel Baluta (OSS) Dec. 9, 2021, 5:46 p.m. UTC

From: Allen-KH Cheng <[e-mail]>

In SOF OF device, pm_runtime_put_autosuspend() is not
matching any pm_runtime_get_sync().

This is imbalanced for PM runtime.

Also, for consistency we call pm_runtime_mark_last_busy()
before enabling PM runtime.

1. Remove pm_runtime_put_autosuspend() in probe_complete
2. Reorder PM runtime calls int probe_complete

Signed-off-by: Allen-KH Cheng <[e-mail]>
Reviewed-by: Daniel Baluta <[e-mail]>
Reviewed-by: Paul Olaru <[e-mail]>
Reviewed-by: Pierre-Louis Bossart <[e-mail]>
---
 sound/soc/sof/sof-of-dev.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Mark Brown Dec. 9, 2021, 7:16 p.m. UTC | #1

On Thu, Dec 09, 2021 at 07:46:57PM +0200, Daniel Baluta wrote:
> 
> Signed-off-by: Allen-KH Cheng <[e-mail]>
> Reviewed-by: Daniel Baluta <[e-mail]>
> Reviewed-by: Paul Olaru <[e-mail]>
> Reviewed-by: Pierre-Louis Bossart <[e-mail]>
> ---


You've not provided a Signed-off-by for this so I can't do anything with
it, please see Documentation/process/submitting-patches.rst for details
on what this is and why it's important.

Patch

diff --git a/sound/soc/sof/sof-of-dev.c b/sound/soc/sof/sof-of-dev.c
index 412cbb824b84..b0089698eecb 100644
--- a/sound/soc/sof/sof-of-dev.c
+++ b/sound/soc/sof/sof-of-dev.c
@@ -74,11 +74,9 @@  static void sof_of_probe_complete(struct device *dev)
 	/* allow runtime_pm */
 	pm_runtime_set_autosuspend_delay(dev, SND_SOF_SUSPEND_DELAY_MS);
 	pm_runtime_use_autosuspend(dev);
+	pm_runtime_mark_last_busy(dev);
 	pm_runtime_set_active(dev);
 	pm_runtime_enable(dev);
-
-	pm_runtime_mark_last_busy(dev);
-	pm_runtime_put_autosuspend(dev);
 }
 
 static int sof_of_probe(struct platform_device *pdev)