| Message ID | 20211216160229.17049-1-digetx@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3bf4fb25d5c2455396a1decd43f5e6b775f0b377 |
| Headers | show |
| Series | [v1] dt-bindings: sound: tegra-audio-rt5677: Correct example | expand |
16.12.2021 19:02, Dmitry Osipenko пишет: > Remove non-existent properties from the example of the binding. These > properties were borrower from the old txt binding, but they were never > used in practice and aren't documented in the new binding. They aren't > reported by the binding checker because dtschema needs extra patch that > hasn't been upstreamed yet to make unevaluatedProperties work properly. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > .../devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml > index 03ff691c26c8..a49997d6028b 100644 > --- a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml > @@ -92,9 +92,6 @@ examples: > nvidia,audio-codec = <&rt5677>; > > nvidia,hp-det-gpios = <&gpio 143 0>; > - nvidia,mic-present-gpios = <&gpio 132 1>; > - nvidia,hp-en-gpios = <&rt5677 1 0>; > - nvidia,dmic-clk-en-gpios = <&rt5677 2 1>; > > clocks = <&clk 216>, > <&clk 217>, > Interestingly, I can't find any Tegra device-tree that uses this rt5677 binding. Maybe we should remove it?
On Thu, 16 Dec 2021 19:02:29 +0300, Dmitry Osipenko wrote: > Remove non-existent properties from the example of the binding. These > properties were borrower from the old txt binding, but they were never > used in practice and aren't documented in the new binding. They aren't > reported by the binding checker because dtschema needs extra patch that > hasn't been upstreamed yet to make unevaluatedProperties work properly. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > .../devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml | 3 --- > 1 file changed, 3 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, Dec 16, 2021 at 07:02:29PM +0300, Dmitry Osipenko wrote: > Remove non-existent properties from the example of the binding. These > properties were borrower from the old txt binding, but they were never Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On Thu, 16 Dec 2021 19:02:29 +0300, Dmitry Osipenko wrote: > Remove non-existent properties from the example of the binding. These > properties were borrower from the old txt binding, but they were never > used in practice and aren't documented in the new binding. They aren't > reported by the binding checker because dtschema needs extra patch that > hasn't been upstreamed yet to make unevaluatedProperties work properly. > > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] dt-bindings: sound: tegra-audio-rt5677: Correct example commit: 3bf4fb25d5c2455396a1decd43f5e6b775f0b377 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml index 03ff691c26c8..a49997d6028b 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml @@ -92,9 +92,6 @@ examples: nvidia,audio-codec = <&rt5677>; nvidia,hp-det-gpios = <&gpio 143 0>; - nvidia,mic-present-gpios = <&gpio 132 1>; - nvidia,hp-en-gpios = <&rt5677 1 0>; - nvidia,dmic-clk-en-gpios = <&rt5677 2 1>; clocks = <&clk 216>, <&clk 217>,
Remove non-existent properties from the example of the binding. These properties were borrower from the old txt binding, but they were never used in practice and aren't documented in the new binding. They aren't reported by the binding checker because dtschema needs extra patch that hasn't been upstreamed yet to make unevaluatedProperties work properly. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- .../devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml | 3 --- 1 file changed, 3 deletions(-)