| Message ID | 20220304004543.11797-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next,v2] ASoC: amd: Fix an ignored error return from platform_get_irq_byname() | expand |
On Fri, Mar 04, 2022 at 08:45:43AM +0800, Yang Li wrote: > The return from the call to platform_get_irq_byname() is int, it can be > a negative error code, however this is being assigned to an unsigned > int variable 'adata->i2s_irq', so assign the value to 'ret' concurrently > to solve this problem without affecting other functions. This doesn't apply against current code, please check and resend.
On Fri, Mar 04, 2022 at 08:45:43AM +0800, Yang Li wrote: > The return from the call to platform_get_irq_byname() is int, it can be > a negative error code, however this is being assigned to an unsigned > int variable 'adata->i2s_irq', so assign the value to 'ret' concurrently > to solve this problem without affecting other functions. This doesn't apply against current code, please check and resend.
diff --git a/sound/soc/amd/acp/acp-renoir.c b/sound/soc/amd/acp/acp-renoir.c index 738cf2e2b973..21e5c9744784 100644 --- a/sound/soc/amd/acp/acp-renoir.c +++ b/sound/soc/amd/acp/acp-renoir.c @@ -282,9 +282,9 @@ static int renoir_audio_probe(struct platform_device *pdev) if (!adata->acp_base) return -ENOMEM; - adata->i2s_irq = platform_get_irq_byname(pdev, "acp_dai_irq"); - if (adata->i2s_irq < 0) - return -ENODEV; + adata->i2s_irq = ret = platform_get_irq_byname(pdev, "acp_dai_irq"); + if (ret < 0) + return ret; adata->dev = dev; adata->dai_driver = acp_renoir_dai;
The return from the call to platform_get_irq_byname() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'adata->i2s_irq', so assign the value to 'ret' concurrently to solve this problem without affecting other functions. Eliminate the following coccicheck warning: ./sound/soc/amd/acp/acp-renoir.c:286:5-19: WARNING: Unsigned expression compared with zero: adata -> i2s_irq < 0 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Fixes: 3304a242f45a ("ASoC: amd: Use platform_get_irq_byname() to get the interrupt") Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- --Changes in v2: Report the error code is being returned rather than squashing it down to -ENODEV. sound/soc/amd/acp/acp-renoir.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)