| Message ID | 20220325154241.1600757-4-broonie@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 01251dd004d8e106295c3aa8e3ba890f0dd55e02 |
| Headers | show |
| Series | ASoC: atmel: Fixes for AT91SAM9G20-EK audio driver | expand |
On 25.03.2022 17:42, Mark Brown wrote: > The AT91SAM9G20-EK audio driver is replacing any error code returned by > atmel_ssc_set_audio() with -EINVAL which could be unhelpful for debugging. > Pass through the error code, and include it in the log message we print for > good measure. > > Signed-off-by: Mark Brown <broonie@kernel.org> Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Thanks!
diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c index d771843011ea..0365b583ba70 100644 --- a/sound/soc/atmel/sam9g20_wm8731.c +++ b/sound/soc/atmel/sam9g20_wm8731.c @@ -127,8 +127,8 @@ static int at91sam9g20ek_audio_probe(struct platform_device *pdev) ret = atmel_ssc_set_audio(0); if (ret) { - dev_err(&pdev->dev, "ssc channel is not valid\n"); - return -EINVAL; + dev_err(&pdev->dev, "ssc channel is not valid: %d\n", ret); + return ret; } card->dev = &pdev->dev;
The AT91SAM9G20-EK audio driver is replacing any error code returned by atmel_ssc_set_audio() with -EINVAL which could be unhelpful for debugging. Pass through the error code, and include it in the log message we print for good measure. Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/atmel/sam9g20_wm8731.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)