| Message ID | 20220423133154.141027-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: dt-bindings: renesas,rz-ssi: Document RZ/G2UL SoC | expand |
On 23/04/2022 15:31, Biju Das wrote: > Document RZ/G2U2L SSI bindings. RZ/G2UL SSI is identical to one found > on the RZ/G2L SoC. No driver changes are required as generic compatible > string "renesas,rz-ssi" will be used as a fallback. > > While at it add a '.' at the end of dmas description for the first cell. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Sat, Apr 23, 2022 at 3:32 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Document RZ/G2U2L SSI bindings. RZ/G2UL SSI is identical to one found > on the RZ/G2L SoC. No driver changes are required as generic compatible > string "renesas,rz-ssi" will be used as a fallback. > > While at it add a '.' at the end of dmas description for the first cell. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi All, Gentle ping. Are we happy with this patch? Please let me know. Cheers, Biju > Subject: [PATCH] ASoC: dt-bindings: renesas,rz-ssi: Document RZ/G2UL SoC > > Document RZ/G2U2L SSI bindings. RZ/G2UL SSI is identical to one found on > the RZ/G2L SoC. No driver changes are required as generic compatible > string "renesas,rz-ssi" will be used as a fallback. > > While at it add a '.' at the end of dmas description for the first cell. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > index 7e8d252f7bca..0d9840375132 100644 > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > @@ -13,6 +13,7 @@ properties: > compatible: > items: > - enum: > + - renesas,r9a07g043-ssi # RZ/G2UL > - renesas,r9a07g044-ssi # RZ/G2{L,LC} > - renesas,r9a07g054-ssi # RZ/V2L > - const: renesas,rz-ssi > @@ -50,7 +51,7 @@ properties: > minItems: 1 > maxItems: 2 > description: > - The first cell represents a phandle to dmac > + The first cell represents a phandle to dmac. > The second cell specifies the encoded MID/RID values of the SSI > port > connected to the DMA client and the slave channel configuration > parameters. > -- > 2.25.1
On Tue, Jun 07, 2022 at 10:49:22AM +0000, Biju Das wrote: > Hi All, > > Gentle ping. > > Are we happy with this patch? Please let me know. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled. Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed.
Hi Mark, Thanks for the feedback. > Subject: Re: [PATCH] ASoC: dt-bindings: renesas,rz-ssi: Document RZ/G2UL > SoC > > On Tue, Jun 07, 2022 at 10:49:22AM +0000, Biju Das wrote: > > Hi All, > > > > Gentle ping. > > > > Are we happy with this patch? Please let me know. > > Please don't send content free pings and please allow a reasonable time > for review. People get busy, go on holiday, attend conferences and so > on so unless there is some reason for urgency (like critical bug fixes) > please allow at least a couple of weeks for review. If there have been > review comments then people may be waiting for those to be addressed. OK. Agreed. > > Sending content free pings adds to the mail volume (if they are seen at > all) which is often the problem and since they can't be reviewed > directly if something has gone wrong you'll have to resend the patches > anyway, so sending again is generally a better approach though there are > some other maintainers who like them - if in doubt look at how patches > for the subsystem are normally handled. OK. Will rebase and resend this patch. > > Please don't top post, reply in line with needed context. This allows > readers to readily follow the flow of conversation and understand what > you are talking about and also helps ensure that everything in the > discussion is being addressed. Agreed. Regards, Biju
diff --git a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml index 7e8d252f7bca..0d9840375132 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml @@ -13,6 +13,7 @@ properties: compatible: items: - enum: + - renesas,r9a07g043-ssi # RZ/G2UL - renesas,r9a07g044-ssi # RZ/G2{L,LC} - renesas,r9a07g054-ssi # RZ/V2L - const: renesas,rz-ssi @@ -50,7 +51,7 @@ properties: minItems: 1 maxItems: 2 description: - The first cell represents a phandle to dmac + The first cell represents a phandle to dmac. The second cell specifies the encoded MID/RID values of the SSI port connected to the DMA client and the slave channel configuration parameters.
Document RZ/G2U2L SSI bindings. RZ/G2UL SSI is identical to one found on the RZ/G2L SoC. No driver changes are required as generic compatible string "renesas,rz-ssi" will be used as a fallback. While at it add a '.' at the end of dmas description for the first cell. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)