From patchwork Tue Apr 26 23:56:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bard Liao X-Patchwork-Id: 12828086 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 794F5C433F5 for ; Tue, 26 Apr 2022 23:58:26 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9D6F71753; Wed, 27 Apr 2022 01:57:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9D6F71753 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1651017504; bh=7gZI640vB7Fkwj7DXZ769dDtNYXHXh9PsK5UHotqXzY=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Yt8MhIBWlhNzEJDgNdq+3gUWhMnJQ/HdBWGeyLfMhAzF6CCujDxCskzBb5wIqx4t5 OPe9QF/Qj8IPCBMbtwyiQDPEbOdCcmycUGtByeI2IfGuz2KrhlyfotKG948ZrUCrNu LWlk1qAbDRFGKm2zfm9FL8QOFIhoUERumhEOfJOM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 338AEF80152; Wed, 27 Apr 2022 01:56:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0DDF7F8027D; Wed, 27 Apr 2022 01:56:47 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 57F0DF80105 for ; Wed, 27 Apr 2022 01:56:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 57F0DF80105 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="U7SRFAxn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651017401; x=1682553401; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7gZI640vB7Fkwj7DXZ769dDtNYXHXh9PsK5UHotqXzY=; b=U7SRFAxnX2F4tf/RwoR/nAdk+4R9skSNhyTqPbdAmM9McAUvXsXB+W2t E9HGaPt9lthE8rDZKpxnocNOzeoZ22AqlihaRsbf164F8lAUCl4n2S3P3 NHu68PjhLHp+rEaAPMNJZquHj8F9nVnoBH/gILhCXkTg2ZghB9YFhnfwG OTaK7TXQIdrH2gruidymjWRCNmbGZ8bC/V86HENWTKdQ9lagGBqxQ2BuY pS6XNZFPl2Dy5YbBJpmadRcoDGVO6qIgU6n6tTwaUBPDw4QULV8gGzJYV wcj5HXLgRm3r2hDCrHntuYrSITtUfktqOQQ6Q/H68w/shwgwAhiSyREjk g==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="290908842" X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="290908842" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 16:56:33 -0700 X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="730515015" Received: from htamura-mobl2.gar.corp.intel.com (HELO bard-pc.domain.name) ([10.252.185.30]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 16:56:31 -0700 From: Bard Liao To: alsa-devel@alsa-project.org, vkoul@kernel.org Subject: [PATCH 1/5] soundwire: qcom: return error when pm_runtime_get_sync fails Date: Wed, 27 Apr 2022 07:56:19 +0800 Message-Id: <20220426235623.4253-2-yung-chuan.liao@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220426235623.4253-1-yung-chuan.liao@linux.intel.com> References: <20220426235623.4253-1-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Cc: vinod.koul@linaro.org, gregkh@linuxfoundation.org, pierre-louis.bossart@linux.intel.com, linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org, sanyog.r.kale@intel.com, bard.liao@intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Pierre-Louis Bossart For some reason there's a missing error return in two places. Fixes: 74e79da9fd46a ("soundwire: qcom: add runtime pm support") Fixes: 04d46a7b38375 ("soundwire: qcom: add in-band wake up interrupt support") Signed-off-by: Pierre-Louis Bossart Reviewed-by: Péter Ujfalusi Signed-off-by: Bard Liao Reviewed-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index f5fc8c27012a..c40c25f2d264 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -516,6 +516,7 @@ static irqreturn_t qcom_swrm_wake_irq_handler(int irq, void *dev_id) "pm_runtime_get_sync failed in %s, ret %d\n", __func__, ret); pm_runtime_put_noidle(swrm->dev); + return ret; } if (swrm->wake_irq > 0) { @@ -1258,6 +1259,7 @@ static int swrm_reg_show(struct seq_file *s_file, void *data) "pm_runtime_get_sync failed in %s, ret %d\n", __func__, ret); pm_runtime_put_noidle(swrm->dev); + return ret; } for (reg = 0; reg <= SWR_MSTR_MAX_REG_ADDR; reg += 4) {