diff mbox series

[6/6] ASoC: wm8903: Fix the error handling of wm8903_i2c_probe()

Message ID 20220510153251.1741210-7-zheyuma97@gmail.com (mailing list archive)
State Accepted
Commit 83d1b65d4cbe6fb0bbdacc18c1f4ad0450275d8f
Headers show
Series ASOC: Fix the error handling code of the probe | expand

Commit Message

Zheyu Ma May 10, 2022, 3:32 p.m. UTC 
The driver should goto label 'err' when failing to request the irq.

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
---
 sound/soc/codecs/wm8903.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Charles Keepax May 10, 2022, 3:56 p.m. UTC | #1 
On Tue, May 10, 2022 at 11:32:51PM +0800, Zheyu Ma wrote:
> The driver should goto label 'err' when failing to request the irq.
> 
> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
diff mbox series

Patch

diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c
index ddcef11dce7c..3c95c2aea515 100644
--- a/sound/soc/codecs/wm8903.c
+++ b/sound/soc/codecs/wm8903.c
@@ -2131,7 +2131,7 @@  static int wm8903_i2c_probe(struct i2c_client *i2c)
 		if (ret != 0) {
 			dev_err(wm8903->dev, "Failed to request IRQ: %d\n",
 				ret);
-			return ret;
+			goto err;
 		}
 
 		/* Enable write sequencer interrupts */