| Message ID | 20220603124609.4024666-1-broonie@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6bda28a2f7113b1c49eb05155ace02b75bccae7b |
| Headers | show |
| Series | ASoC: wcd9335: Fix spurious event generation | expand |
On Fri, 3 Jun 2022 14:46:09 +0200, Mark Brown wrote: > The slimbus mux put operation unconditionally reports a change in value > which means that spurious events are generated. Fix this by exiting early > in that case. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: wcd9335: Fix spurious event generation commit: 6bda28a2f7113b1c49eb05155ace02b75bccae7b All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 617a36a89dfe..d25594a708e0 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -1287,6 +1287,9 @@ static int slim_rx_mux_put(struct snd_kcontrol *kc, struct snd_soc_dapm_update *update = NULL; u32 port_id = w->shift; + if (wcd->rx_port_value[port_id] == ucontrol->value.enumerated.item[0]) + return 0; + wcd->rx_port_value[port_id] = ucontrol->value.enumerated.item[0]; switch (wcd->rx_port_value[port_id]) {
The slimbus mux put operation unconditionally reports a change in value which means that spurious events are generated. Fix this by exiting early in that case. Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/codecs/wcd9335.c | 3 +++ 1 file changed, 3 insertions(+)