From patchwork Tue Jul 5 09:26:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12906154 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BC35C43334 for ; Tue, 5 Jul 2022 09:28:15 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3A92B16E3; Tue, 5 Jul 2022 11:27:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3A92B16E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657013293; bh=qDxgHKU+doIhEne6ScFlapgjylf1pJ+0Tr9JEKNAYEY=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=L+JV00eQdE2umtZrs/sXsUZLZ4AY8KVPBjM8CNG6HzR99b2G5dTAlYr1/iIQL4Cut 7e1fBY6huMQLx0RSC3fHfY2hrVhn4Bs3hxZNyC3+biorwY7rvReD7HkARLGMJ1aCbF 0PuWLTdFg1l5RRN5wFkzcq+LwrN0xoQZhFNPcnmc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CB162F80153; Tue, 5 Jul 2022 11:27:22 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7A3C0F800CB; Tue, 5 Jul 2022 11:27:21 +0200 (CEST) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7E084F800CB for ; Tue, 5 Jul 2022 11:27:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7E084F800CB Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8epq-0006Bm-KO; Tue, 05 Jul 2022 11:27:10 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o8epk-004XSE-Ay; Tue, 05 Jul 2022 11:27:07 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o8epn-0037i9-3c; Tue, 05 Jul 2022 11:27:07 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown Subject: [PATCH] ASoC: xilinx: Suppress second error message about reset failure in .remove() Date: Tue, 5 Jul 2022 11:26:45 +0200 Message-Id: <20220705092645.101343-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1129; h=from:subject; bh=qDxgHKU+doIhEne6ScFlapgjylf1pJ+0Tr9JEKNAYEY=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBixAPS7RESMsGyow+QX+KR/Iz7pFWBq2U40Ie995C+ k3NwGYGJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYsQD0gAKCRDB/BR4rcrsCU32CA CClenbIgn9YVIMowqp2NKMgCNBkpQ8mICVwgFsnXx04PhpgCsdXWrLfTX5/R8F+qDYzyubbNpQiN50 uoQwuiNbhGdDz7X71OdOyH0jRpupNU2pZZYHsJwR4ANMuHS5Y/10w2dha5L1tRgk1o6j50t3AePyyN fdq7ixn2PM2q5aET5S5Oh2VtFkmhuJiGki/PDZj7pPo3ZJ+jCM21qlmnlr/N3I7/a/aqBLRqGPBhxw xh+JovndIyiQFMGeoSToXeb3IDzJlSfWa1hCttqnabWX0O8j7ns2iOzxPBjzyyRTd1XCOPKokgU3Ca f4FanvAapQKFgWwAWXiePqNE/7Clp7 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Cc: linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Michal Simek , kernel@pengutronix.de X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Returning an error value in a platform remove callback results in an error message being emitted by the platform core, but otherwise it doesn't make a difference. If ret is != 0, there is already an error message and another very generic doesn't add any value, so return 0 unconditionally. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König --- sound/soc/xilinx/xlnx_formatter_pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56 diff --git a/sound/soc/xilinx/xlnx_formatter_pcm.c b/sound/soc/xilinx/xlnx_formatter_pcm.c index 5c4158069a5a..c42de48caea5 100644 --- a/sound/soc/xilinx/xlnx_formatter_pcm.c +++ b/sound/soc/xilinx/xlnx_formatter_pcm.c @@ -703,7 +703,7 @@ static int xlnx_formatter_pcm_remove(struct platform_device *pdev) dev_err(&pdev->dev, "audio formatter reset failed\n"); clk_disable_unprepare(adata->axi_clk); - return ret; + return 0; } static const struct of_device_id xlnx_formatter_pcm_of_match[] = {