| Message ID | 20220722134603.316668-1-Syed.SabaKareem@amd.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | be0aa8d4b0fcb4532bf7973141e911998ab39508 |
| Headers | show |
| Series | ASoC: amd: yc: Update DMI table entries | expand |
[Public] > -----Original Message----- > From: syed sabakareem <Syed.SabaKareem@amd.com> > Sent: Friday, July 22, 2022 08:46 > To: broonie@kernel.org; alsa-devel@alsa-project.org > Cc: Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; Deucher, > Alexander <Alexander.Deucher@amd.com>; Hiregoudar, Basavaraj > <Basavaraj.Hiregoudar@amd.com>; Dommati, Sunil-kumar <Sunil- > kumar.Dommati@amd.com>; markpearson@lenovo.com; Limonciello, Mario > <Mario.Limonciello@amd.com>; Saba Kareem, Syed > <Syed.SabaKareem@amd.com>; Liam Girdwood <lgirdwood@gmail.com>; > Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; > Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; open list <linux- > kernel@vger.kernel.org> > Subject: [PATCH] ASoC: amd: yc: Update DMI table entries > > Removed intel DMI product id's 21AW/21AX/21D8/21D9/21BN/21BQ > in DMI table and updated DMI entry for AMD platform X13 Gen 3 > platform 21CM/21CN. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216267 Syed thanks for the quick patch on this issue. I just noticed one more tag to add for the reporter of this that Mark can pick up when he pulls this in. Reported-by: David Korth <gerbilsoft@gerbilsoft.com> Also suggest Mark this to consider to pull back to @stable, mostly because of the X13 IDs missing. > > Signed-off-by: syed sabakareem <Syed.SabaKareem@amd.com> > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> > --- > sound/soc/amd/yc/acp6x-mach.c | 32 ++------------------------------ > 1 file changed, 2 insertions(+), 30 deletions(-) > > diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x- > mach.c > index f06e6c1a7799..ecfe7a790790 100644 > --- a/sound/soc/amd/yc/acp6x-mach.c > +++ b/sound/soc/amd/yc/acp6x-mach.c > @@ -105,28 +105,14 @@ static const struct dmi_system_id > yc_acp_quirk_table[] = { > .driver_data = &acp6x_card, > .matches = { > DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), > - DMI_MATCH(DMI_PRODUCT_NAME, "21AW"), > + DMI_MATCH(DMI_PRODUCT_NAME, "21CM"), > } > }, > { > .driver_data = &acp6x_card, > .matches = { > DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), > - DMI_MATCH(DMI_PRODUCT_NAME, "21AX"), > - } > - }, > - { > - .driver_data = &acp6x_card, > - .matches = { > - DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), > - DMI_MATCH(DMI_PRODUCT_NAME, "21BN"), > - } > - }, > - { > - .driver_data = &acp6x_card, > - .matches = { > - DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), > - DMI_MATCH(DMI_PRODUCT_NAME, "21BQ"), > + DMI_MATCH(DMI_PRODUCT_NAME, "21CN"), > } > }, > { > @@ -157,20 +143,6 @@ static const struct dmi_system_id > yc_acp_quirk_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "21CL"), > } > }, > - { > - .driver_data = &acp6x_card, > - .matches = { > - DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), > - DMI_MATCH(DMI_PRODUCT_NAME, "21D8"), > - } > - }, > - { > - .driver_data = &acp6x_card, > - .matches = { > - DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), > - DMI_MATCH(DMI_PRODUCT_NAME, "21D9"), > - } > - }, > {} > }; > > -- > 2.25.1
On Fri, 22 Jul 2022 16:46:40 +0200, Limonciello, Mario wrote: > > [Public] > > > -----Original Message----- > > From: syed sabakareem <Syed.SabaKareem@amd.com> > > Sent: Friday, July 22, 2022 08:46 > > To: broonie@kernel.org; alsa-devel@alsa-project.org > > Cc: Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; Deucher, > > Alexander <Alexander.Deucher@amd.com>; Hiregoudar, Basavaraj > > <Basavaraj.Hiregoudar@amd.com>; Dommati, Sunil-kumar <Sunil- > > kumar.Dommati@amd.com>; markpearson@lenovo.com; Limonciello, Mario > > <Mario.Limonciello@amd.com>; Saba Kareem, Syed > > <Syed.SabaKareem@amd.com>; Liam Girdwood <lgirdwood@gmail.com>; > > Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; > > Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; open list <linux- > > kernel@vger.kernel.org> > > Subject: [PATCH] ASoC: amd: yc: Update DMI table entries > > > > Removed intel DMI product id's 21AW/21AX/21D8/21D9/21BN/21BQ > > in DMI table and updated DMI entry for AMD platform X13 Gen 3 > > platform 21CM/21CN. > > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216267 > > Syed thanks for the quick patch on this issue. > I just noticed one more tag to add for the reporter of this that Mark can pick up when he pulls this in. > > Reported-by: David Korth <gerbilsoft@gerbilsoft.com> > > Also suggest Mark this to consider to pull back to @stable, mostly because of the X13 IDs missing. Put Fixes tag pointing to the commit ID that introduced the issue in addition to Cc-to-stable tag in the patch. This makes it easier to be picked up for stable trees. thanks, Takashi
[Public] > -----Original Message----- > From: Takashi Iwai <tiwai@suse.de> > Sent: Friday, July 22, 2022 09:49 > To: Limonciello, Mario <Mario.Limonciello@amd.com> > Cc: Saba Kareem, Syed <Syed.SabaKareem@amd.com>; > broonie@kernel.org; alsa-devel@alsa-project.org; Mukunda, Vijendar > <Vijendar.Mukunda@amd.com>; Deucher, Alexander > <Alexander.Deucher@amd.com>; Hiregoudar, Basavaraj > <Basavaraj.Hiregoudar@amd.com>; Dommati, Sunil-kumar <Sunil- > kumar.Dommati@amd.com>; markpearson@lenovo.com; Liam Girdwood > <lgirdwood@gmail.com>; Jaroslav Kysela <perex@perex.cz>; Takashi Iwai > <tiwai@suse.com>; open list <linux-kernel@vger.kernel.org>; > gerbilsoft@gerbilsoft.com > Subject: Re: [PATCH] ASoC: amd: yc: Update DMI table entries > > On Fri, 22 Jul 2022 16:46:40 +0200, > Limonciello, Mario wrote: > > > > [Public] > > > > > -----Original Message----- > > > From: syed sabakareem <Syed.SabaKareem@amd.com> > > > Sent: Friday, July 22, 2022 08:46 > > > To: broonie@kernel.org; alsa-devel@alsa-project.org > > > Cc: Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; Deucher, > > > Alexander <Alexander.Deucher@amd.com>; Hiregoudar, Basavaraj > > > <Basavaraj.Hiregoudar@amd.com>; Dommati, Sunil-kumar <Sunil- > > > kumar.Dommati@amd.com>; markpearson@lenovo.com; Limonciello, > Mario > > > <Mario.Limonciello@amd.com>; Saba Kareem, Syed > > > <Syed.SabaKareem@amd.com>; Liam Girdwood > <lgirdwood@gmail.com>; > > > Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; > > > Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; open list <linux- > > > kernel@vger.kernel.org> > > > Subject: [PATCH] ASoC: amd: yc: Update DMI table entries > > > > > > Removed intel DMI product id's 21AW/21AX/21D8/21D9/21BN/21BQ > > > in DMI table and updated DMI entry for AMD platform X13 Gen 3 > > > platform 21CM/21CN. > > > > > > Link: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz > illa.kernel.org%2Fshow_bug.cgi%3Fid%3D216267&data=05%7C01%7CM > ario.Limonciello%40amd.com%7Ca50898fc385f447a436108da6bf15b31%7C3d > d8961fe4884e608e11a82d994e183d%7C0%7C0%7C637940981608875195%7CU > nknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI > 6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ukJGUsVoH > MSqnjlflOUuQD%2B7dSV2gy8qunjKHkEHQHY%3D&reserved=0 > > > > Syed thanks for the quick patch on this issue. > > I just noticed one more tag to add for the reporter of this that Mark can > pick up when he pulls this in. > > > > Reported-by: David Korth <gerbilsoft@gerbilsoft.com> > > > > Also suggest Mark this to consider to pull back to @stable, mostly because > of the X13 IDs missing. > > Put Fixes tag pointing to the commit ID that introduced the issue in > addition to Cc-to-stable tag in the patch. This makes it easier to be > picked up for stable trees. > > Good point, here's a tag for it: Fixes: fa991481b8b2 ("ASoC: amd: add YC machine driver using dmic")
On Fri, 22 Jul 2022 19:15:32 +0530, syed sabakareem wrote: > Removed intel DMI product id's 21AW/21AX/21D8/21D9/21BN/21BQ > in DMI table and updated DMI entry for AMD platform X13 Gen 3 > platform 21CM/21CN. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216267 > > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: amd: yc: Update DMI table entries commit: be0aa8d4b0fcb4532bf7973141e911998ab39508 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index f06e6c1a7799..ecfe7a790790 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -105,28 +105,14 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { .driver_data = &acp6x_card, .matches = { DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_NAME, "21AW"), + DMI_MATCH(DMI_PRODUCT_NAME, "21CM"), } }, { .driver_data = &acp6x_card, .matches = { DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_NAME, "21AX"), - } - }, - { - .driver_data = &acp6x_card, - .matches = { - DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_NAME, "21BN"), - } - }, - { - .driver_data = &acp6x_card, - .matches = { - DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_NAME, "21BQ"), + DMI_MATCH(DMI_PRODUCT_NAME, "21CN"), } }, { @@ -157,20 +143,6 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "21CL"), } }, - { - .driver_data = &acp6x_card, - .matches = { - DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_NAME, "21D8"), - } - }, - { - .driver_data = &acp6x_card, - .matches = { - DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_NAME, "21D9"), - } - }, {} };