| Message ID | 20220803204442.2996580-1-justinstitt@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b7bf23c0865faac61564425ddc96a4a79ebf19b0 |
| Headers | show |
| Series | [resend] ASoC: SOF: ipc3-topology: Fix clang -Wformat warning | expand |
On Wed, Aug 03, 2022 at 01:44:42PM -0700, Justin Stitt wrote: > When building with Clang we encounter these warnings: > | sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type > | 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] > | SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); > | ^~~~~~~~~~~~~~~^~~~~~~~~~~~~~~^~~~~~~~~~~~~ > > Use correct format specifier `%d` since args are of type int. > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Reported-by: Nathan Chancellor <nathan@kernel.org> > Suggested-by: Nathan Chancellor <nathan@kernel.org> > Signed-off-by: Justin Stitt <justinstitt@google.com> Thanks for resending! Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > Note: resending with the subject corrected, this patch fixes a build > warning that will break the Clang build when CONFIG_WERROR=y. > > Original patch: https://lore.kernel.org/all/20220721211218.4039288-1-justinstitt@google.com/ > Reported by Nathan here: https://lore.kernel.org/all/YtmrCJjQrSbv8Aj1@dev-arch.thelio-3990X/ > > sound/soc/sof/ipc3-topology.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/ipc3-topology.c b/sound/soc/sof/ipc3-topology.c > index b2cc046b9f60..65923e7a5976 100644 > --- a/sound/soc/sof/ipc3-topology.c > +++ b/sound/soc/sof/ipc3-topology.c > @@ -2338,7 +2338,7 @@ static int sof_ipc3_parse_manifest(struct snd_soc_component *scomp, int index, > } > > dev_info(scomp->dev, > - "Topology: ABI %d:%d:%d Kernel ABI %hhu:%hhu:%hhu\n", > + "Topology: ABI %d:%d:%d Kernel ABI %d:%d:%d\n", > man->priv.data[0], man->priv.data[1], man->priv.data[2], > SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); > > -- > 2.37.1.359.gd136c6c3e2-goog >
On 8/3/22 15:47, Nathan Chancellor wrote: > On Wed, Aug 03, 2022 at 01:44:42PM -0700, Justin Stitt wrote: >> When building with Clang we encounter these warnings: >> | sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type >> | 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] >> | SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); >> | ^~~~~~~~~~~~~~~^~~~~~~~~~~~~~~^~~~~~~~~~~~~ >> >> Use correct format specifier `%d` since args are of type int. >> >> Link: https://github.com/ClangBuiltLinux/linux/issues/378 >> Reported-by: Nathan Chancellor <nathan@kernel.org> >> Suggested-by: Nathan Chancellor <nathan@kernel.org> >> Signed-off-by: Justin Stitt <justinstitt@google.com> > > Thanks for resending! > > Reviewed-by: Nathan Chancellor <nathan@kernel.org> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > >> --- >> Note: resending with the subject corrected, this patch fixes a build >> warning that will break the Clang build when CONFIG_WERROR=y. >> >> Original patch: https://lore.kernel.org/all/20220721211218.4039288-1-justinstitt@google.com/ >> Reported by Nathan here: https://lore.kernel.org/all/YtmrCJjQrSbv8Aj1@dev-arch.thelio-3990X/ >> >> sound/soc/sof/ipc3-topology.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/sof/ipc3-topology.c b/sound/soc/sof/ipc3-topology.c >> index b2cc046b9f60..65923e7a5976 100644 >> --- a/sound/soc/sof/ipc3-topology.c >> +++ b/sound/soc/sof/ipc3-topology.c >> @@ -2338,7 +2338,7 @@ static int sof_ipc3_parse_manifest(struct snd_soc_component *scomp, int index, >> } >> >> dev_info(scomp->dev, >> - "Topology: ABI %d:%d:%d Kernel ABI %hhu:%hhu:%hhu\n", >> + "Topology: ABI %d:%d:%d Kernel ABI %d:%d:%d\n", >> man->priv.data[0], man->priv.data[1], man->priv.data[2], >> SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); >> >> -- >> 2.37.1.359.gd136c6c3e2-goog >>
On Wed, 3 Aug 2022 13:44:42 -0700, Justin Stitt wrote: > When building with Clang we encounter these warnings: > | sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type > | 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] > | SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); > | ^~~~~~~~~~~~~~~^~~~~~~~~~~~~~~^~~~~~~~~~~~~ > > Use correct format specifier `%d` since args are of type int. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: ipc3-topology: Fix clang -Wformat warning commit: b7bf23c0865faac61564425ddc96a4a79ebf19b0 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/sof/ipc3-topology.c b/sound/soc/sof/ipc3-topology.c index b2cc046b9f60..65923e7a5976 100644 --- a/sound/soc/sof/ipc3-topology.c +++ b/sound/soc/sof/ipc3-topology.c @@ -2338,7 +2338,7 @@ static int sof_ipc3_parse_manifest(struct snd_soc_component *scomp, int index, } dev_info(scomp->dev, - "Topology: ABI %d:%d:%d Kernel ABI %hhu:%hhu:%hhu\n", + "Topology: ABI %d:%d:%d Kernel ABI %d:%d:%d\n", man->priv.data[0], man->priv.data[1], man->priv.data[2], SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH);
When building with Clang we encounter these warnings: | sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type | 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] | SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); | ^~~~~~~~~~~~~~~^~~~~~~~~~~~~~~^~~~~~~~~~~~~ Use correct format specifier `%d` since args are of type int. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Reported-by: Nathan Chancellor <nathan@kernel.org> Suggested-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Justin Stitt <justinstitt@google.com> --- Note: resending with the subject corrected, this patch fixes a build warning that will break the Clang build when CONFIG_WERROR=y. Original patch: https://lore.kernel.org/all/20220721211218.4039288-1-justinstitt@google.com/ Reported by Nathan here: https://lore.kernel.org/all/YtmrCJjQrSbv8Aj1@dev-arch.thelio-3990X/ sound/soc/sof/ipc3-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)