| Message ID | 20220815162906.463108-1-sbinding@opensource.cirrus.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4d4c4bff4f8ed79d95e0592aed6c6144d558a236 |
| Headers | show |
| Series | [v2] ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties | expand |
On Mon, 15 Aug 2022 18:29:06 +0200, Stefan Binding wrote: > > For devices which use HID CSC3551, correct ACPI _DSD properties are > required to be able support those systems. > Add error message to clarify this. > > Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com> Thanks, applied. Takashi
diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index 129bffb431c2..15e2a0009080 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -1163,6 +1163,11 @@ static int cs35l41_no_acpi_dsd(struct cs35l41_hda *cs35l41, struct device *physd hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH; hw_cfg->gpio1.valid = true; } else { + /* + * Note: CLSA010(0/1) are special cases which use a slightly different design. + * All other HIDs e.g. CSC3551 require valid ACPI _DSD properties to be supported. + */ + dev_err(cs35l41->dev, "Error: ACPI _DSD Properties are missing for HID %s.\n", hid); hw_cfg->valid = false; hw_cfg->gpio1.valid = false; hw_cfg->gpio2.valid = false;
For devices which use HID CSC3551, correct ACPI _DSD properties are required to be able support those systems. Add error message to clarify this. Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com> --- sound/pci/hda/cs35l41_hda.c | 5 +++++ 1 file changed, 5 insertions(+)