ASoC: SOF: compress: Remove dai_posn variable

Commit Message

Daniel Baluta (OSS) Aug. 22, 2022, 5:49 p.m. UTC

From: Daniel Baluta <[e-mail]>

dai_posn is set but never used. Initial intention was
to use dai_posn to shorthen one code line but it looks fine
without it too.

Fixes: c1a731c71359 ("ASoC: SOF: compress: Add support for computing timestamps")
Reported-by: kernel test robot <[e-mail]>
Signed-off-by: Daniel Baluta <[e-mail]>
---
 sound/soc/sof/compress.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Mark Brown Aug. 23, 2022, 6:49 p.m. UTC | #1

On Mon, 22 Aug 2022 20:49:37 +0300, Daniel Baluta wrote:
> From: Daniel Baluta <[e-mail]>
> 
> dai_posn is set but never used. Initial intention was
> to use dai_posn to shorthen one code line but it looks fine
> without it too.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: compress: Remove dai_posn variable
      commit: d45f552a1e44e2885c4b7551564241959d8138be

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Patch

diff --git a/sound/soc/sof/compress.c b/sound/soc/sof/compress.c
index 174b3d8e67dd..c8ae778a50d1 100644
--- a/sound/soc/sof/compress.c
+++ b/sound/soc/sof/compress.c
@@ -327,7 +327,6 @@  static int sof_compr_pointer(struct snd_soc_component *component,
 			     struct snd_compr_stream *cstream,
 			     struct snd_compr_tstamp *tstamp)
 {
-	u64 dai_posn;
 	struct snd_sof_pcm *spcm;
 	struct snd_soc_pcm_runtime *rtd = cstream->private_data;
 	struct sof_compr_stream *sstream = cstream->runtime->private_data;
@@ -336,8 +335,6 @@  static int sof_compr_pointer(struct snd_soc_component *component,
 	if (!spcm)
 		return -EINVAL;
 
-	dai_posn = spcm->stream[cstream->direction].posn.dai_posn;
-
 	tstamp->sampling_rate = sstream->sampling_rate;
 	tstamp->copied_total = sstream->copied_total;
 	tstamp->pcm_io_frames = div_u64(spcm->stream[cstream->direction].posn.dai_posn,