| Message ID | 20220826093659.1059276-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5b7f4e5de61ba8c44317718936864da29eeba62a |
| Headers | show |
| Series | ASoC: codecs: allow compile testing without MFD drivers | expand |
On Fri, Aug 26, 2022 at 12:36:59PM +0300, Krzysztof Kozlowski wrote: > Motorola CPCAP, Lochnagar Sound, Rockchip RK817 and Qualcomm > WCD9340/WCD9341 do not depend on parent MFD driver in build time and can > be compile tested without respective MFD part for increased build > coverage. Although generally it's easy enough to just turn on the MFDs themselves, it's not the same base platform issue as the firmware interfaces can be.
On 26/08/2022 21:35, Mark Brown wrote: > On Fri, Aug 26, 2022 at 12:36:59PM +0300, Krzysztof Kozlowski wrote: >> Motorola CPCAP, Lochnagar Sound, Rockchip RK817 and Qualcomm >> WCD9340/WCD9341 do not depend on parent MFD driver in build time and can >> be compile tested without respective MFD part for increased build >> coverage. > > Although generally it's easy enough to just turn on the MFDs > themselves, it's not the same base platform issue as the firmware > interfaces can be. True, it's not the same build coverage need as subsystem/interface dependencies, but still: 1. Drivers can be built independently, so why not? 2. There is no drawback in allowing to building them independently (compile test). 3. The parent MFD device could also depend on something (RK817 and MFD_LOCHNAGAR depends on I2C and OF; CPCAP on SPI), so it's not always the case of just enabling parent. IOW, you can compile test codecs without I2C and SPI which is valuable itself. I find the last reason actually quite valid and applicable here. If you wish I can add it to the commit msg. Best regards, Krzysztof
On Fri, 26 Aug 2022 12:36:59 +0300, Krzysztof Kozlowski wrote: > Motorola CPCAP, Lochnagar Sound, Rockchip RK817 and Qualcomm > WCD9340/WCD9341 do not depend on parent MFD driver in build time and can > be compile tested without respective MFD part for increased build > coverage. > > Applied to broonie/sound.git for-next Thanks! [1/1] ASoC: codecs: allow compile testing without MFD drivers commit: 5b7f4e5de61ba8c44317718936864da29eeba62a All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Sat, Aug 27, 2022 at 12:02:39PM +0300, Krzysztof Kozlowski wrote: > True, it's not the same build coverage need as subsystem/interface > dependencies, but still: > 1. Drivers can be built independently, so why not? > 2. There is no drawback in allowing to building them independently > (compile test). > 3. The parent MFD device could also depend on something (RK817 and > MFD_LOCHNAGAR depends on I2C and OF; CPCAP on SPI), so it's not always > the case of just enabling parent. IOW, you can compile test codecs > without I2C and SPI which is valuable itself. > I find the last reason actually quite valid and applicable here. If you > wish I can add it to the commit msg. You've already found one case where there's a dependency being pulled in by the parent, I suspect there's more. There's a tradeoff between getting coverage and having to deal with the noise from randconfigs.
On 30/08/2022 13:35, Mark Brown wrote: > On Sat, Aug 27, 2022 at 12:02:39PM +0300, Krzysztof Kozlowski wrote: > >> True, it's not the same build coverage need as subsystem/interface >> dependencies, but still: >> 1. Drivers can be built independently, so why not? >> 2. There is no drawback in allowing to building them independently >> (compile test). >> 3. The parent MFD device could also depend on something (RK817 and >> MFD_LOCHNAGAR depends on I2C and OF; CPCAP on SPI), so it's not always >> the case of just enabling parent. IOW, you can compile test codecs >> without I2C and SPI which is valuable itself. > >> I find the last reason actually quite valid and applicable here. If you >> wish I can add it to the commit msg. > > You've already found one case where there's a dependency being > pulled in by the parent, I suspect there's more. There's a > tradeoff between getting coverage and having to deal with the > noise from randconfigs. Yeah, that was my mistake because did not spot it has "select REGMAP_I2C". For such cases the benefit is indeed gone. Best regards, Krzysztof
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 5926b33ba09e..94b7bb85d236 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -610,7 +610,7 @@ config SND_SOC_BT_SCO config SND_SOC_CPCAP tristate "Motorola CPCAP codec" - depends on MFD_CPCAP + depends on MFD_CPCAP || COMPILE_TEST config SND_SOC_CQ0093VC tristate @@ -972,7 +972,7 @@ config SND_SOC_LM49453 config SND_SOC_LOCHNAGAR_SC tristate "Lochnagar Sound Card" - depends on MFD_LOCHNAGAR + depends on MFD_LOCHNAGAR || COMPILE_TEST help This driver support the sound card functionality of the Cirrus Logic Lochnagar audio development board. @@ -1197,7 +1197,7 @@ config SND_SOC_RK3328 config SND_SOC_RK817 tristate "Rockchip RK817 audio CODEC" - depends on MFD_RK808 + depends on MFD_RK808 || COMPILE_TEST select REGMAP_I2C config SND_SOC_RL6231 @@ -1745,7 +1745,7 @@ config SND_SOC_WCD934X tristate "WCD9340/WCD9341 Codec" depends on COMMON_CLK select SND_SOC_WCD_MBHC - depends on MFD_WCD934X + depends on MFD_WCD934X || COMPILE_TEST help The WCD9340/9341 is a audio codec IC Integrated in Qualcomm SoCs like SDM845.
Motorola CPCAP, Lochnagar Sound, Rockchip RK817 and Qualcomm WCD9340/WCD9341 do not depend on parent MFD driver in build time and can be compile tested without respective MFD part for increased build coverage. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- sound/soc/codecs/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)