| Message ID | 20220911145713.55199-2-mike.rudenko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] ASoC: sunxi: sun4i-codec: silence misleading error in probe | expand |
Dne nedelja, 11. september 2022 ob 16:57:12 CEST je Mikhail Rudenko napisal(a): > At present, succesfull probing of H3 Codec results in an error > > debugfs: Directory '1c22c00.codec' with parent 'H3 Audio Codec' already > present! > > This is caused by a directory name conflict between codec > components. Fix it by setting debugfs_prefix for the CPU DAI > component. > > Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > --- > sound/soc/sunxi/sun4i-codec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c > index 01b461c64d68..4d118f271e8c 100644 > --- a/sound/soc/sunxi/sun4i-codec.c > +++ b/sound/soc/sunxi/sun4i-codec.c > @@ -1253,6 +1253,7 @@ static const struct snd_soc_component_driver > sun8i_a23_codec_codec = { > > static const struct snd_soc_component_driver sun4i_codec_component = { > .name = "sun4i-codec", > + .debugfs_prefix = "dai", > }; > > #define SUN4I_CODEC_RATES SNDRV_PCM_RATE_CONTINUOUS
On Sun, Sep 11, 2022 at 05:57:12PM +0300, Mikhail Rudenko wrote: > At present, succesfull probing of H3 Codec results in an error > > debugfs: Directory '1c22c00.codec' with parent 'H3 Audio Codec' already present! > > This is caused by a directory name conflict between codec > components. Fix it by setting debugfs_prefix for the CPU DAI > component. This doesn't apply against current code, please check and resend.
diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c index 01b461c64d68..4d118f271e8c 100644 --- a/sound/soc/sunxi/sun4i-codec.c +++ b/sound/soc/sunxi/sun4i-codec.c @@ -1253,6 +1253,7 @@ static const struct snd_soc_component_driver sun8i_a23_codec_codec = { static const struct snd_soc_component_driver sun4i_codec_component = { .name = "sun4i-codec", + .debugfs_prefix = "dai", }; #define SUN4I_CODEC_RATES SNDRV_PCM_RATE_CONTINUOUS
At present, succesfull probing of H3 Codec results in an error debugfs: Directory '1c22c00.codec' with parent 'H3 Audio Codec' already present! This is caused by a directory name conflict between codec components. Fix it by setting debugfs_prefix for the CPU DAI component. Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com> --- sound/soc/sunxi/sun4i-codec.c | 1 + 1 file changed, 1 insertion(+)