diff mbox series

[-next] ASoC: Intel: skylake: remove unnecessary dev_set_drvdata()

Message ID 20220916140757.681414-1-yangyingliang@huawei.com (mailing list archive)
State Accepted
Commit d508260e89a7d1889bbb5788fdfc52cc3eb8ddb6
Headers show
Series [-next] ASoC: Intel: skylake: remove unnecessary dev_set_drvdata() | expand

Commit Message

Yang Yingliang Sept. 16, 2022, 2:07 p.m. UTC
Remove unnecessary dev_set_drvdata() in skl_remove(), the driver_data
will be set to NULL in device_unbind_cleanup() after calling ->remove().

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 sound/soc/intel/skylake/skl.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Mark Brown Sept. 27, 2022, 10:34 a.m. UTC | #1
On Fri, 16 Sep 2022 22:07:57 +0800, Yang Yingliang wrote:
> Remove unnecessary dev_set_drvdata() in skl_remove(), the driver_data
> will be set to NULL in device_unbind_cleanup() after calling ->remove().
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: skylake: remove unnecessary dev_set_drvdata()
      commit: d508260e89a7d1889bbb5788fdfc52cc3eb8ddb6

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
index 52a041d6144c..22d9873d12d7 100644
--- a/sound/soc/intel/skylake/skl.c
+++ b/sound/soc/intel/skylake/skl.c
@@ -1152,7 +1152,6 @@  static void skl_remove(struct pci_dev *pci)
 	if (skl->nhlt)
 		intel_nhlt_free(skl->nhlt);
 	skl_free(bus);
-	dev_set_drvdata(&pci->dev, NULL);
 }
 
 /* PCI IDs */