diff mbox series

[linux-next] ALSA: hda/ca0132 - remove the unneeded result variable

Message ID 20220922112846.236987-1-ye.xingchen@zte.com.cn (mailing list archive)
State Accepted
Commit b5eee17cf7ddaf7b29a031b2c48277038e7a171a
Headers show
Series [linux-next] ALSA: hda/ca0132 - remove the unneeded result variable | expand

Commit Message

CGEL Sept. 22, 2022, 11:28 a.m. UTC 
From: ye xingchen <ye.xingchen@zte.com.cn>

Return the value dsp_allocate_ports() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 sound/pci/hda/patch_ca0132.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Takashi Iwai Sept. 22, 2022, 11:53 a.m. UTC | #1 
On Thu, 22 Sep 2022 13:28:46 +0200,
cgel.zte@gmail.com wrote:
> 
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Return the value dsp_allocate_ports() directly instead of storing it in
> another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Thanks, applied.


Takashi
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index 208933792787..9580fe00cbd9 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -2962,7 +2962,6 @@  static int dsp_allocate_ports_format(struct hda_codec *codec,
 			const unsigned short fmt,
 			unsigned int *port_map)
 {
-	int status;
 	unsigned int num_chans;
 
 	unsigned int sample_rate_div = ((get_hdafmt_rate(fmt) >> 0) & 3) + 1;
@@ -2976,9 +2975,7 @@  static int dsp_allocate_ports_format(struct hda_codec *codec,
 
 	num_chans = get_hdafmt_chs(fmt) + 1;
 
-	status = dsp_allocate_ports(codec, num_chans, rate_multi, port_map);
-
-	return status;
+	return dsp_allocate_ports(codec, num_chans, rate_multi, port_map);
 }
 
 /*