| Message ID | 20220922134458.3421695-1-info@benjaminmarty.ch (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: nau8822: add spk boost and spk btl options | expand |
On 2022/9/22 下午 09:44, Benjamin Marty wrote: > These two options are required to use the Speaker output on this codec > to its full potential, when wiring up the Speaker in an BTL configuration. > > The Speaker Boost flag is explained in the Datasheet on page 80. > The Speaker BTL flag is explained in the Datasheet on page 78. > > Signed-off-by: Benjamin Marty <info@benjaminmarty.ch> > --- > sound/soc/codecs/nau8822.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sound/soc/codecs/nau8822.c b/sound/soc/codecs/nau8822.c > index 1aef281a9972..812b8254f9a0 100644 > --- a/sound/soc/codecs/nau8822.c > +++ b/sound/soc/codecs/nau8822.c > @@ -379,6 +379,12 @@ static const struct snd_kcontrol_new nau8822_snd_controls[] = { > NAU8822_REG_DAC_CONTROL, 5, 1, 0), > SOC_SINGLE("ADC 128x Oversampling Switch", > NAU8822_REG_ADC_CONTROL, 5, 1, 0), > + > + SOC_SINGLE("Speaker Gain Boost Control", > + NAU8822_REG_OUTPUT_CONTROL, 2, 1, 0), > + > + SOC_SINGLE("Speaker BTL Configuration", > + NAU8822_REG_RIGHT_SPEAKER_CONTROL, 4, 1, 0), > }; > > /* LMAIN and RMAIN Mixer */ Looks good to me, thanks. But please add the right maintainer Mark Brown <broonie@kernel.org> for patch review. Acked-by: David Lin <CTLIN0@nuvoton.com>
Am Fr., 14. Okt. 2022 um 10:28 Uhr schrieb AS50 CTLin0 <ctlin0@nuvoton.com>: > > On 2022/9/22 下午 09:44, Benjamin Marty wrote: > > These two options are required to use the Speaker output on this codec > > to its full potential, when wiring up the Speaker in an BTL configuration. > > > > The Speaker Boost flag is explained in the Datasheet on page 80. > > The Speaker BTL flag is explained in the Datasheet on page 78. > > > > Signed-off-by: Benjamin Marty <info@benjaminmarty.ch> > > --- > > sound/soc/codecs/nau8822.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/sound/soc/codecs/nau8822.c b/sound/soc/codecs/nau8822.c > > index 1aef281a9972..812b8254f9a0 100644 > > --- a/sound/soc/codecs/nau8822.c > > +++ b/sound/soc/codecs/nau8822.c > > @@ -379,6 +379,12 @@ static const struct snd_kcontrol_new nau8822_snd_controls[] = { > > NAU8822_REG_DAC_CONTROL, 5, 1, 0), > > SOC_SINGLE("ADC 128x Oversampling Switch", > > NAU8822_REG_ADC_CONTROL, 5, 1, 0), > > + > > + SOC_SINGLE("Speaker Gain Boost Control", > > + NAU8822_REG_OUTPUT_CONTROL, 2, 1, 0), > > + > > + SOC_SINGLE("Speaker BTL Configuration", > > + NAU8822_REG_RIGHT_SPEAKER_CONTROL, 4, 1, 0), > > }; > > > > /* LMAIN and RMAIN Mixer */ > > Looks good to me, thanks. > But please add the right maintainer Mark Brown <broonie@kernel.org> for > patch review. > > Acked-by: David Lin <CTLIN0@nuvoton.com> > > ________________________________ > ________________________________ > The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton. > Thanks, how can I add someone on this existing Patch? Or should I just resubmit the Patch?
On 2022/10/14 下午 04:32, Benjamin Marty wrote: > Am Fr., 14. Okt. 2022 um 10:28 Uhr schrieb AS50 CTLin0 <ctlin0@nuvoton.com>: >> On 2022/9/22 下午 09:44, Benjamin Marty wrote: >>> These two options are required to use the Speaker output on this codec >>> to its full potential, when wiring up the Speaker in an BTL configuration. >>> >>> The Speaker Boost flag is explained in the Datasheet on page 80. >>> The Speaker BTL flag is explained in the Datasheet on page 78. >>> >>> Signed-off-by: Benjamin Marty <info@benjaminmarty.ch> >>> --- >>> sound/soc/codecs/nau8822.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/sound/soc/codecs/nau8822.c b/sound/soc/codecs/nau8822.c >>> index 1aef281a9972..812b8254f9a0 100644 >>> --- a/sound/soc/codecs/nau8822.c >>> +++ b/sound/soc/codecs/nau8822.c >>> @@ -379,6 +379,12 @@ static const struct snd_kcontrol_new nau8822_snd_controls[] = { >>> NAU8822_REG_DAC_CONTROL, 5, 1, 0), >>> SOC_SINGLE("ADC 128x Oversampling Switch", >>> NAU8822_REG_ADC_CONTROL, 5, 1, 0), >>> + >>> + SOC_SINGLE("Speaker Gain Boost Control", >>> + NAU8822_REG_OUTPUT_CONTROL, 2, 1, 0), >>> + >>> + SOC_SINGLE("Speaker BTL Configuration", >>> + NAU8822_REG_RIGHT_SPEAKER_CONTROL, 4, 1, 0), >>> }; >>> >>> /* LMAIN and RMAIN Mixer */ >> Looks good to me, thanks. >> But please add the right maintainer Mark Brown <broonie@kernel.org> for >> patch review. >> >> Acked-by: David Lin <CTLIN0@nuvoton.com> >> >> ________________________________ >> ________________________________ >> The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton. >> > Thanks, how can I add someone on this existing Patch? Or should I just > resubmit the Patch? Yes, you need to resubmit with right maintainer. He review/apply the patches from his inbox. :)
diff --git a/sound/soc/codecs/nau8822.c b/sound/soc/codecs/nau8822.c index 1aef281a9972..812b8254f9a0 100644 --- a/sound/soc/codecs/nau8822.c +++ b/sound/soc/codecs/nau8822.c @@ -379,6 +379,12 @@ static const struct snd_kcontrol_new nau8822_snd_controls[] = { NAU8822_REG_DAC_CONTROL, 5, 1, 0), SOC_SINGLE("ADC 128x Oversampling Switch", NAU8822_REG_ADC_CONTROL, 5, 1, 0), + + SOC_SINGLE("Speaker Gain Boost Control", + NAU8822_REG_OUTPUT_CONTROL, 2, 1, 0), + + SOC_SINGLE("Speaker BTL Configuration", + NAU8822_REG_RIGHT_SPEAKER_CONTROL, 4, 1, 0), }; /* LMAIN and RMAIN Mixer */
These two options are required to use the Speaker output on this codec to its full potential, when wiring up the Speaker in an BTL configuration. The Speaker Boost flag is explained in the Datasheet on page 80. The Speaker BTL flag is explained in the Datasheet on page 78. Signed-off-by: Benjamin Marty <info@benjaminmarty.ch> --- sound/soc/codecs/nau8822.c | 6 ++++++ 1 file changed, 6 insertions(+)