| Message ID | 20221029082001.3207380-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 46cf1954de3f324dc7f9472c12c3bd03b268a11b |
| Headers | show |
| Series | [RESEND] ARM: pxa: pxa2xx-ac97-lib: fix return value check of platform_get_irq() | expand |
On Sat, 29 Oct 2022 10:20:01 +0200, Yang Yingliang wrote: > > platform_get_irq() returns negative error number on failure, fix the > return value check in pxa2xx_ac97_hw_probe() and assign the error code > to 'ret'. > > Fixes: 2548e6c76ebf ("ARM: pxa: pxa2xx-ac97-lib: use IRQ resource") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Thanks, applied. Takashi
diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c index e55c0421718b..2ca33fd5a575 100644 --- a/sound/arm/pxa2xx-ac97-lib.c +++ b/sound/arm/pxa2xx-ac97-lib.c @@ -402,8 +402,10 @@ int pxa2xx_ac97_hw_probe(struct platform_device *dev) goto err_clk2; irq = platform_get_irq(dev, 0); - if (!irq) + if (irq < 0) { + ret = irq; goto err_irq; + } ret = request_irq(irq, pxa2xx_ac97_irq, 0, "AC97", NULL); if (ret < 0)
platform_get_irq() returns negative error number on failure, fix the return value check in pxa2xx_ac97_hw_probe() and assign the error code to 'ret'. Fixes: 2548e6c76ebf ("ARM: pxa: pxa2xx-ac97-lib: use IRQ resource") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- The previous link: https://lore.kernel.org/lkml/20220425074559.2436002-1-yangyingliang@huawei.com/T/#u --- sound/arm/pxa2xx-ac97-lib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)