| Message ID | 20221122200841.1026335-1-butterflyhuangxx@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ALSA: rawmidi: fix infoleak in snd_rawmidi_ioctl_status_compat64 | expand |
diff --git a/sound/core/rawmidi_compat.c b/sound/core/rawmidi_compat.c index 68a93443583c..6afa68165b17 100644 --- a/sound/core/rawmidi_compat.c +++ b/sound/core/rawmidi_compat.c @@ -80,6 +80,7 @@ static int snd_rawmidi_ioctl_status_compat64(struct snd_rawmidi_file *rfile, if (err < 0) return err; + memset(&compat_status, 0, sizeof(compat_status)); compat_status = (struct compat_snd_rawmidi_status64) { .stream = status.stream, .tstamp_sec = status.tstamp_sec,
The compat_status is declared off of the stack, so it needs to be zeroed out before copied back to userspace to prevent any unintentional data leakage. Signed-off-by: Xiaolong Huang <butterflyhuangxx@gmail.com> --- sound/core/rawmidi_compat.c | 1 + 1 file changed, 1 insertion(+) base-commit: eb7081409f94a9a8608593d0fb63a1aa3d6f95d8