| Message ID | 20221223170404.210603-2-francesco@dolcini.it (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: nau8822: add speaker Bridge Tied Output | expand |
On Fri, 23 Dec 2022 18:04:02 +0100, Francesco Dolcini wrote: > From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> > > Convert nau8822 devicetree binding to dtschema. > Change file name to match dtschema naming. > > Cc: David Lin <CTLIN0@nuvoton.com> > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > .../devicetree/bindings/sound/nau8822.txt | 16 -------- > .../bindings/sound/nuvoton,nau8822.yaml | 40 +++++++++++++++++++ > 2 files changed, 40 insertions(+), 16 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/nau8822.txt > create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221223170404.210603-2-francesco@dolcini.it audio-codec@1a: '#sound-dai-cells', 'AVDD-supply', 'CPVDD-supply', 'DBVDD-supply', 'DCVDD-supply', 'MICVDD-supply', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb
On 23/12/2022 18:04, Francesco Dolcini wrote: > From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> > > Convert nau8822 devicetree binding to dtschema. > Change file name to match dtschema naming. > > Cc: David Lin <CTLIN0@nuvoton.com> > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > .../devicetree/bindings/sound/nau8822.txt | 16 -------- > .../bindings/sound/nuvoton,nau8822.yaml | 40 +++++++++++++++++++ > 2 files changed, 40 insertions(+), 16 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/nau8822.txt > create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml > > diff --git a/Documentation/devicetree/bindings/sound/nau8822.txt b/Documentation/devicetree/bindings/sound/nau8822.txt > deleted file mode 100644 > index a471d162d4e5..000000000000 > --- a/Documentation/devicetree/bindings/sound/nau8822.txt > +++ /dev/null > @@ -1,16 +0,0 @@ > -NAU8822 audio CODEC > - > -This device supports I2C only. > - > -Required properties: > - > - - compatible : "nuvoton,nau8822" > - > - - reg : the I2C address of the device. > - > -Example: > - > -codec: nau8822@1a { > - compatible = "nuvoton,nau8822"; > - reg = <0x1a>; > -}; > diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml > new file mode 100644 > index 000000000000..10464170a98f > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nuvoton,nau8822.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NAU8822 audio CODEC > + > +description: | > + 24 bit stereo audio codec with speaker driver. > + This device supports I2C/SPI. Currently, only I2C bus is supported. I would skip the last sentence - bindings are independent of OS, so the sentence might be not true in different systems/versions. > + > +maintainers: > + - David Lin <CTLIN0@nuvoton.com> > + > +properties: > + compatible: > + enum: > + - nuvoton,nau8822 > + > + reg: > + maxItems: 1 > + > +additionalProperties: false Please put "additionalProperties" after "required:". With above (or even without these): Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Il 23 dicembre 2022 20:26:02 CET, Rob Herring <robh@kernel.org> ha scritto: > >On Fri, 23 Dec 2022 18:04:02 +0100, Francesco Dolcini wrote: >> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> >> >> Convert nau8822 devicetree binding to dtschema. >> Change file name to match dtschema naming. >> >> Cc: David Lin <CTLIN0@nuvoton.com> >> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> >> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> >> --- >> .../devicetree/bindings/sound/nau8822.txt | 16 -------- >> .../bindings/sound/nuvoton,nau8822.yaml | 40 +++++++++++++++++++ >> 2 files changed, 40 insertions(+), 16 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/sound/nau8822.txt >> create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml >> > >Running 'make dtbs_check' with the schema in this patch gives the >following warnings. Consider if they are expected or the schema is >incorrect. These may not be new warnings. > Expected, those DTS files needs to be fixed, I'll have a separate patch for those. >Note that it is not yet a requirement to have 0 warnings for dtbs_check. >This will change in the future. > >Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221223170404.210603-2-francesco@dolcini.it > > >audio-codec@1a: '#sound-dai-cells', 'AVDD-supply', 'CPVDD-supply', 'DBVDD-supply', 'DCVDD-supply', 'MICVDD-supply', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb >
diff --git a/Documentation/devicetree/bindings/sound/nau8822.txt b/Documentation/devicetree/bindings/sound/nau8822.txt deleted file mode 100644 index a471d162d4e5..000000000000 --- a/Documentation/devicetree/bindings/sound/nau8822.txt +++ /dev/null @@ -1,16 +0,0 @@ -NAU8822 audio CODEC - -This device supports I2C only. - -Required properties: - - - compatible : "nuvoton,nau8822" - - - reg : the I2C address of the device. - -Example: - -codec: nau8822@1a { - compatible = "nuvoton,nau8822"; - reg = <0x1a>; -}; diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml new file mode 100644 index 000000000000..10464170a98f --- /dev/null +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml @@ -0,0 +1,40 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/nuvoton,nau8822.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NAU8822 audio CODEC + +description: | + 24 bit stereo audio codec with speaker driver. + This device supports I2C/SPI. Currently, only I2C bus is supported. + +maintainers: + - David Lin <CTLIN0@nuvoton.com> + +properties: + compatible: + enum: + - nuvoton,nau8822 + + reg: + maxItems: 1 + +additionalProperties: false + +required: + - compatible + - reg + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + codec@1a { + compatible = "nuvoton,nau8822"; + reg = <0x1a>; + }; + };