| Message ID | 20230208092420.5037-8-kiseok.jo@irondevice.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 677e3ab71f83c71e1482d9698bd8159c44fed93d |
| Headers | show |
| Series | [v2,1/4] ASoC: SMA1303: Remove the I2C Retry property in devicetree | expand |
On 08/02/2023 10:24, Kiseok Jo wrote: > Add the missing properties as compatible, reg, sound-dai-cells. > And then check this file using 'make dt_binding_check'. > > Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com> > --- > .../bindings/sound/irondevice,sma1303.yaml | 23 ++++++++++++++++--- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 08/02/2023 10:34, Krzysztof Kozlowski wrote: > On 08/02/2023 10:24, Kiseok Jo wrote: >> Add the missing properties as compatible, reg, sound-dai-cells. >> And then check this file using 'make dt_binding_check'. >> >> Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com> >> --- >> .../bindings/sound/irondevice,sma1303.yaml | 23 ++++++++++++++++--- > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Wait, no, I see you added some more undocumented properties - at least clk is new. Didn't we learn anything from first submission errors? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml b/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml index 162c52606635..b36c35e5da1a 100644 --- a/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml +++ b/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml @@ -10,22 +10,39 @@ maintainers: - Kiseok Jo <kiseok.jo@irondevice.com> description: - SMA1303 digital class-D audio amplifier with an integrated boost converter. + SMA1303 digital class-D audio amplifier + with an integrated boost converter. allOf: - - $ref: name-prefix.yaml# + - $ref: dai-common.yaml# + +properties: + compatible: + enum: + - irondevice,sma1303 + + reg: + maxItems: 1 + + '#sound-dai-cells': + const: 1 required: - compatible - reg + - '#sound-dai-cells' additionalProperties: false examples: - | - i2c_bus { + i2c { + #address-cells = <1>; + #size-cells = <0>; + amplifier@1e { compatible = "irondevice,sma1303"; reg = <0x1e>; + #sound-dai-cells = <1>; }; };
Add the missing properties as compatible, reg, sound-dai-cells. And then check this file using 'make dt_binding_check'. Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com> --- .../bindings/sound/irondevice,sma1303.yaml | 23 ++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-)