| Message ID | 20230209002548.94496-1-o-takashi@sakamocchi.jp (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 86bdfa267a222c85f95664208e039b94e2ac913b |
| Headers | show |
| Series | ALSA: ppc: fix unused function local variable | expand |
On Thu, 09 Feb 2023 01:25:48 +0100, Takashi Sakamoto wrote: > > The function local variable is not used anymore, while it is left. > > This commit deletes it. > > Fixes: 25a5a77ae0bc ("ALSA: core: Make snd_card_free() return void") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Link: https://lore.kernel.org/r/20230209104823.45899e76@canb.auug.org.au/ > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Thanks, applied. Takashi
On Thu, Feb 09, 2023 at 08:05:10AM +0100, Takashi Iwai wrote: > On Thu, 09 Feb 2023 01:25:48 +0100, > Takashi Sakamoto wrote: > > > > The function local variable is not used anymore, while it is left. > > > > This commit deletes it. > > > > Fixes: 25a5a77ae0bc ("ALSA: core: Make snd_card_free() return void") > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > > Link: https://lore.kernel.org/r/20230209104823.45899e76@canb.auug.org.au/ > > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> > > Thanks, applied. Thanks for cleaning up after me. The patch looks fine. Maybe already to late, but for completeness: Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c index 8d349231205e..a6cff2c46ac7 100644 --- a/sound/ppc/snd_ps3.c +++ b/sound/ppc/snd_ps3.c @@ -1046,7 +1046,6 @@ static int snd_ps3_driver_probe(struct ps3_system_bus_device *dev) /* called when module removal */ static void snd_ps3_driver_remove(struct ps3_system_bus_device *dev) { - int ret; pr_info("%s:start id=%d\n", __func__, dev->match_id); /*
The function local variable is not used anymore, while it is left. This commit deletes it. Fixes: 25a5a77ae0bc ("ALSA: core: Make snd_card_free() return void") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Link: https://lore.kernel.org/r/20230209104823.45899e76@canb.auug.org.au/ Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> --- sound/ppc/snd_ps3.c | 1 - 1 file changed, 1 deletion(-)