| Message ID | 20230216155007.26143-1-jhunkeler@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 22ce6843abec19270bf69b176d7ee0a4ef781da5 |
| Headers | show |
| Series | soc:amd:yp:Add OMEN by HP Gaming Laptop 16z-n000 to quirks | expand |
On Thu, Feb 16, 2023 at 10:50:07AM -0500, Joseph Hunkeler wrote:
> Enables display microphone on the HP OMEN 16z-n000 (8A42) laptop
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
On Thu, 2023-02-16 at 16:23 +0000, Mark Brown wrote: > On Thu, Feb 16, 2023 at 10:50:07AM -0500, Joseph Hunkeler wrote: > > Enables display microphone on the HP OMEN 16z-n000 (8A42) laptop > > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. Hi Mark, I apologize, I don't fully understand what you're asking me to do. I see the typo "yp:" was supposed to be "yc:". I took a quick look at a few other submissions. Are you suggesting I change the email subject from: > [PATCH] soc:amd:yp:Add OMEN by HP Gaming Laptop 16z-n000 to quirks To something like: "[PATCH] ASoC: amd: yc: Add OMEN by HP Gaming Laptop 16z-n000 to quirks table"? If so, do I edit my original message as new, amend the subject, and resend as-is? Or do I reply to the original message with the amended subject along with the full contents of the patch body? I know you said there is no need to resubmit to fix this, but it's is not clear to me how to do it without resubmitting. Thanks, Joe
On Thu, Feb 16, 2023 at 04:25:45PM -0500, Joseph Hunkeler wrote: > On Thu, 2023-02-16 at 16:23 +0000, Mark Brown wrote: > > There's no need to resubmit to fix this alone. > submissions. Are you suggesting I change the email subject from: > > "[PATCH] ASoC: amd: yc: Add OMEN by HP Gaming Laptop 16z-n000 to quirks table"? Yes, exactly. > If so, do I edit my original message as new, amend the subject, and resend > as-is? Or do I reply to the original message with the amended subject along > with the full contents of the patch body? I know you said there is no need > to resubmit to fix this, but it's is not clear to me how to do it without > resubmitting. You'd need to resend to fix it but I'm saying there's no need for you to bother, I fixed it up locally. Please just bear this in mind for future patches.
On Fri, 2023-02-17 at 00:10 +0000, Mark Brown wrote: > You'd need to resend to fix it but I'm saying there's no need for > you to bother, I fixed it up locally. Please just bear this in > mind for future patches. Ah now I get it. Will do. Thank you!
On Thu, 16 Feb 2023 10:50:07 -0500, Joseph Hunkeler wrote: > Enables display microphone on the HP OMEN 16z-n000 (8A42) laptop > > Applied to broonie/sound.git for-next Thanks! [1/1] soc:amd:yp:Add OMEN by HP Gaming Laptop 16z-n000 to quirks commit: 22ce6843abec19270bf69b176d7ee0a4ef781da5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 363147539..4e681e9c0 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -255,6 +255,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "15NBC1011"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "HP"), + DMI_MATCH(DMI_PRODUCT_NAME, "OMEN by HP Gaming Laptop 16z-n000"), + } + }, {} };
Enables display microphone on the HP OMEN 16z-n000 (8A42) laptop Signed-off-by: Joseph Hunkeler <jhunkeler@gmail.com> --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) base-commit: e1c04510f521e853019afeca2a5991a5ef8d6a5b