diff mbox series

[1/3] ASoC: mt6358: Fix event generation for wake on voice stage 2 switch

Message ID 20230224-asoc-mt6358-quick-fixes-v1-1-747d9186be4b@kernel.org (mailing list archive)
State Accepted
Commit 3425ddaea57af77ca96a59a5b8eaa2f9e1b021ba
Headers show
Series ASoC: mt6358: Fixes from an initial glance at a kselftest run | expand

Commit Message

Mark Brown Feb. 26, 2023, 12:47 p.m. UTC 
ALSA control put() operations should return 0 if the value changed so that
events can be generated appropriately for userspace but the custom control
for wake on voice stage 2 doesn't do this, fix it.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/mt6358.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

AngeloGioacchino Del Regno Feb. 27, 2023, 8:55 a.m. UTC | #1 
Il 26/02/23 13:47, Mark Brown ha scritto:
> ALSA control put() operations should return 0 if the value changed so that
> events can be generated appropriately for userspace but the custom control
> for wake on voice stage 2 doesn't do this, fix it.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
diff mbox series

Patch

diff --git a/sound/soc/codecs/mt6358.c b/sound/soc/codecs/mt6358.c
index 93f35e8d26fc..9004377461f7 100644
--- a/sound/soc/codecs/mt6358.c
+++ b/sound/soc/codecs/mt6358.c
@@ -567,6 +567,8 @@  static int mt6358_put_wov(struct snd_kcontrol *kcontrol,
 			mt6358_disable_wov_phase2(priv);
 
 		priv->wov_enabled = enabled;
+
+		return 1;
 	}
 
 	return 0;