From patchwork Tue Mar 14 01:53:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bard Liao X-Patchwork-Id: 13173530 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCDBFC6FD19 for ; Tue, 14 Mar 2023 01:43:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C48E9148F; Tue, 14 Mar 2023 02:43:00 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C48E9148F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678758230; bh=E1vpSUnv0GpopyC7lDUkDQqhHE9rQzhik8od9N+jq4w=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=gYJrZeEwH1MnsB0vKAWtweJyvwGM7sYaOUxk1zgE8yXrVxjboBOKp4cqaQ7s3TObe C9m0TCtPz7FGgEuANgd2k7Go1DvOhNGCTlItA+fbRO9WXWii2OUKU6SnSJc8YA2MFV OvytBKm7vvqsRrsILzXro6QPS+Mgj49vLPEp4qJU= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id D4621F80552; Tue, 14 Mar 2023 02:41:34 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 24C17F8051B; Tue, 14 Mar 2023 02:41:23 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 816D1F80093 for ; Tue, 14 Mar 2023 02:41:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 816D1F80093 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=KwLU1gJw DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678758077; x=1710294077; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=E1vpSUnv0GpopyC7lDUkDQqhHE9rQzhik8od9N+jq4w=; b=KwLU1gJwUJoazSuPnxxKu0cPIZNQVkPYQBLhAIMOHTtQB0QXJstUfejk 9cd7W8QDnF5FmVBRERzqBEd9WRQ+IyFgfdqDiKa2zLNrDphGFKkVNomtu 1MJWXKpgOmIl29HCP24LR7StxSQ90eQdtXNoLgJcZAmy62kjXACUOd0Vx Oci3DesgKDiKBkDjYc80yIBPcOoDrM9GuSgCXcErB64ibvtFM1gRvI/FJ 02ItzuBbJK9l6EUmYV/+Kc6QHTZY8a/ynzj3dtxoybtvtd13wRWSr3682 RmJMYvtR4mcI+wZOWkxy5xyirsjcwnDJeESj6WtXZFNByaXUQaTXOgyOz w==; X-IronPort-AV: E=McAfee;i="6500,9779,10648"; a="316949234" X-IronPort-AV: E=Sophos;i="5.98,258,1673942400"; d="scan'208";a="316949234" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2023 18:41:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10648"; a="711327386" X-IronPort-AV: E=Sophos;i="5.98,258,1673942400"; d="scan'208";a="711327386" Received: from bard-ubuntu.sh.intel.com ([10.239.185.57]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2023 18:41:12 -0700 From: Bard Liao To: alsa-devel@alsa-project.org, vkoul@kernel.org Subject: [PATCH 04/16] soundwire: intel: remove useless abstraction Date: Tue, 14 Mar 2023 09:53:58 +0800 Message-Id: <20230314015410.487311-5-yung-chuan.liao@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314015410.487311-1-yung-chuan.liao@linux.intel.com> References: <20230314015410.487311-1-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Message-ID-Hash: LWI2GJHB3GRXOJZKGWP5W7OVZ4ZN2X4D X-Message-ID-Hash: LWI2GJHB3GRXOJZKGWP5W7OVZ4ZN2X4D X-MailFrom: yung-chuan.liao@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: vinod.koul@linaro.org, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, bard.liao@intel.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Pierre-Louis Bossart PDM is supported in the hardware but never enabled: there are no known PDM-based devices. We can directly call the PCM helper. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Rander Wang Signed-off-by: Bard Liao --- drivers/soundwire/intel.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 6c17baab7923..2c1c905f8889 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -586,13 +586,6 @@ static int intel_pdi_stream_ch_update(struct sdw_intel *sdw, return 0; } -static int intel_pdi_ch_update(struct sdw_intel *sdw) -{ - intel_pdi_stream_ch_update(sdw, &sdw->cdns.pcm); - - return 0; -} - static void intel_pdi_shim_configure(struct sdw_intel *sdw, struct sdw_cdns_pdi *pdi) { @@ -1094,7 +1087,7 @@ static int intel_register_dai(struct sdw_intel *sdw) if (ret) return ret; - intel_pdi_ch_update(sdw); + intel_pdi_stream_ch_update(sdw, &sdw->cdns.pcm); /* DAIs are created based on total number of PDIs supported */ num_dai = cdns->pcm.num_pdi;