From patchwork Wed Mar 15 15:05:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13176062 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 890DBC6FD1D for ; Wed, 15 Mar 2023 15:10:16 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3675F1286; Wed, 15 Mar 2023 16:09:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3675F1286 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678893014; bh=Nv0fFDdpMsYv/AziGAvneOUwDP6WrEsgaTtZmnVlKCs=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=rVPBXaoP05riC4AuHLDFXK3iSoYlRBrBTtwLgxLpivfWL6+p8eg1sc/wkyO8zbaef 1kC1tHC56AkgXy/5DxSTm0JaTj9DbCYRow+vaAUzn1Wcxk0Hul8e8gzhviE/Ps6vP8 lax++InPNhq8RPGnpbPQU+c9rX6co+7FlAHZCXl0= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 41724F805B2; Wed, 15 Mar 2023 16:08:19 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1DAAEF80551; Wed, 15 Mar 2023 16:08:11 +0100 (CET) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 20A77F8051B for ; Wed, 15 Mar 2023 16:08:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 20A77F8051B Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcSjR-00076k-Ax; Wed, 15 Mar 2023 16:08:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pcSjP-004KUH-UP; Wed, 15 Mar 2023 16:07:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pcSjO-0057cP-L6; Wed, 15 Mar 2023 16:07:58 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jaroslav Kysela , Takashi Iwai , Michael Ellerman Subject: [PATCH 010/173] ALSA: ppc/powermac: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 16:05:02 +0100 Message-Id: <20230315150745.67084-11-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1522; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Nv0fFDdpMsYv/AziGAvneOUwDP6WrEsgaTtZmnVlKCs=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkEd1Fc2m0HdG8hA2w0W66WSSsQN5kZZ2uuzZom b2v/sqUuJeJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZBHdRQAKCRDB/BR4rcrs CZ0jCACPrpIlHkrSaBq80LSctZcXy1yzAvLgskca4LBO4LBxyHTTfFqyTugrTL1GHnkHXn20Yd3 qNiV7pzR8UaVog2UzIuYKI/Gi1m2RpaEjbKH1DiowL6BhptZtU2lpFdSarRMoTqSQzhB+mRNSlQ 1i4INPcYOTV4qgeWvJ9WF2kVUTWDx97fFyM/EXzloZXvgcZ6naAHbsep49lw9jSyKf0u615E3Hs CO6gHhimXOCTNEWaRcapCulnRlma6ioLO2QYKmyGdY9hg73FWmMcfzbu9caNUa4Xfkvpd4cof8F /fcHSV3XnyjSoJgJXTbPwrfr7wt8waK16GdZ5ZTLI+tbA/mO X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Message-ID-Hash: IQ3ZC3VKT2O4OYXONQT7UIMFGSW7PMHH X-Message-ID-Hash: IQ3ZC3VKT2O4OYXONQT7UIMFGSW7PMHH X-MailFrom: ukl@pengutronix.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Nicholas Piggin , Christophe Leroy , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, kernel@pengutronix.de X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- sound/ppc/powermac.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/ppc/powermac.c b/sound/ppc/powermac.c index db414b61157e..e17af46abddd 100644 --- a/sound/ppc/powermac.c +++ b/sound/ppc/powermac.c @@ -130,10 +130,9 @@ static int snd_pmac_probe(struct platform_device *devptr) } -static int snd_pmac_remove(struct platform_device *devptr) +static void snd_pmac_remove(struct platform_device *devptr) { snd_card_free(platform_get_drvdata(devptr)); - return 0; } #ifdef CONFIG_PM_SLEEP @@ -161,7 +160,7 @@ static SIMPLE_DEV_PM_OPS(snd_pmac_pm, snd_pmac_driver_suspend, snd_pmac_driver_r static struct platform_driver snd_pmac_driver = { .probe = snd_pmac_probe, - .remove = snd_pmac_remove, + .remove_new = snd_pmac_remove, .driver = { .name = SND_PMAC_DRIVER, .pm = SND_PMAC_PM_OPS,