From patchwork Wed Mar 15 15:07:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13176222 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CC4EC6FD1D for ; Wed, 15 Mar 2023 15:42:28 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 354A613FE; Wed, 15 Mar 2023 16:41:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 354A613FE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678894946; bh=tnODiljTLK15/CS2OsFoa5VvK7w5J4TXLKQzsjADB4I=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=MplKTmo+1PnXtvCJz1dZuCMC1fxs1jqxMw591gwrAdMUQCBR6qrwLnDGSE2Tj/2gX RTipOS3lxKf7cncj5J2wKMJkTP6FAnEnP5m1mCck9ZTaMEyjSZmCMY4Tm5r5/quZ8v gDNEyI7OdWJvpm1r+00CvW+rEQ60nxQXjHIfsIQA= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 68512F80C6F; Wed, 15 Mar 2023 16:15:11 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A39EFF805F8; Wed, 15 Mar 2023 16:10:19 +0100 (CET) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 03E97F80611 for ; Wed, 15 Mar 2023 16:08:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 03E97F80611 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcSk4-0000lh-Gk; Wed, 15 Mar 2023 16:08:40 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pcSjz-004Kh7-PY; Wed, 15 Mar 2023 16:08:35 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pcSjz-0057mz-06; Wed, 15 Mar 2023 16:08:35 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jaroslav Kysela , Takashi Iwai Subject: [PATCH 173/173] ALSA: sparc/dbri: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 16:07:45 +0100 Message-Id: <20230315150745.67084-174-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1530; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=tnODiljTLK15/CS2OsFoa5VvK7w5J4TXLKQzsjADB4I=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkEd8524mR0C9pJ38zGVnTjjy0E8kbujcu8I+Xw MNtKRP9+NCJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZBHfOQAKCRDB/BR4rcrs CYYRCACDH2o+1hGEaoMSI7cCEytkeycvy2up/uigiH7ROimgeJumYuQGR0nPDHN+qhmcBq5DzHh 0Ql371359kW3rn/3P81yMmhSRyTMj9vJCty+FynVUnGq1Y89WR1opyvMu5x1EQPdzgKr82uckYA rr9OIciBQpxRVhLh5Uo/mhRlIJnaEX0GlXYL6FW6Jffuk+heNGd+X3zLRtFy3d0zvRE1m9Lg7QF 0oXYYoPsO8LoHoG0iWshJiaFnqq3mI0hDuz6NQV1onfLxLAs/ZqkhR/2erT+90G8DWQh/+KzLaU JoIY2Oxd4ShbiBlQFvwO2aYqNT1ejWTNikrlimAObguXZp1L X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Message-ID-Hash: A7BBCS67T2MY7NNHQYQ5NBQAFUH7PWWE X-Message-ID-Hash: A7BBCS67T2MY7NNHQYQ5NBQAFUH7PWWE X-MailFrom: ukl@pengutronix.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, kernel@pengutronix.de X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- sound/sparc/dbri.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c index 3881e1c1b08a..376aed136a45 100644 --- a/sound/sparc/dbri.c +++ b/sound/sparc/dbri.c @@ -2656,14 +2656,12 @@ static int dbri_probe(struct platform_device *op) return err; } -static int dbri_remove(struct platform_device *op) +static void dbri_remove(struct platform_device *op) { struct snd_card *card = dev_get_drvdata(&op->dev); snd_dbri_free(card->private_data); snd_card_free(card); - - return 0; } static const struct of_device_id dbri_match[] = { @@ -2684,7 +2682,7 @@ static struct platform_driver dbri_sbus_driver = { .of_match_table = dbri_match, }, .probe = dbri_probe, - .remove = dbri_remove, + .remove_new = dbri_remove, }; module_platform_driver(dbri_sbus_driver);