From patchwork Wed Mar 15 15:05:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13176122 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B2E6C61DA4 for ; Wed, 15 Mar 2023 15:19:17 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 55A9A1257; Wed, 15 Mar 2023 16:18:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 55A9A1257 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678893555; bh=gVmQ2LG4FEG5o+QO3u7Ff0dmh2zPnPIqpyigSB2evR0=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=byX+89AbsuF7xnzO4zrYjJCwsru/AkHDBKy/s1IyGH/pBDhlnhICMDkjk0Of/uCkO efBkmwx7LF7O/TqZxJElIGqZv3vMMAi0Laz0g+dIpvugXoZp2Q7ulS4TPKGxrkGL/J psbJ6Cn6pb1bt4G/e079P4RDJBr1uBWkwHe9nsSo= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 1AE77F80619; Wed, 15 Mar 2023 16:10:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 77513F80652; Wed, 15 Mar 2023 16:08:54 +0100 (CET) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id ECC09F8057E for ; Wed, 15 Mar 2023 16:08:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz ECC09F8057E Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcSjV-0007Ku-83; Wed, 15 Mar 2023 16:08:05 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pcSjU-004KVy-Bi; Wed, 15 Mar 2023 16:08:04 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pcSjT-0057do-5P; Wed, 15 Mar 2023 16:08:03 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Codrin Ciubotariu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Subject: [PATCH 031/173] ASoC: atmel: sam9g20_wm8731: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 16:05:23 +0100 Message-Id: <20230315150745.67084-32-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1712; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=gVmQ2LG4FEG5o+QO3u7Ff0dmh2zPnPIqpyigSB2evR0=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkEd2Gqm/5mmz/SaGW/HcgXBKDsS35JLeW2hQRB nYmuy46x/2JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZBHdhgAKCRDB/BR4rcrs CW7dB/9DNjfTVXBbG+A1NYJw7mX1Ujb39pvaDmbqyau7SGwdoI7iqgjGIU/5fxUG0L+K00A41Wu djWn8/ahvS+r3ipOXw46KVqglflx1iMCPyGeJidqdrOGpdeIaqD+rlC8Qk1wW9Tw6nye09niJYY vPV9A8gjceideas2qEbU0DHoyiqEYHYFlguZBIiCIDtUnfZCgva0/rkdB01NuFgaONTLNyk+eA7 w9yDgDQRhjp7YXgGc6aULElH/o97ziu1qIlV1oyFzqCIMiJxhiHuQH+HbwKXnTFACTD1SmQ36ZS /2ERxsUkuQJK9s65veaHhlR4RbdE8Yc0Qb9Egpm5WIekFDtK X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Message-ID-Hash: EW5ICIBZ5NHDP5RTWSXZGK6DYD2JVJAF X-Message-ID-Hash: EW5ICIBZ5NHDP5RTWSXZGK6DYD2JVJAF X-MailFrom: ukl@pengutronix.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Claudiu Beznea --- sound/soc/atmel/sam9g20_wm8731.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c index 785b9d01d8af..baf38964b491 100644 --- a/sound/soc/atmel/sam9g20_wm8731.c +++ b/sound/soc/atmel/sam9g20_wm8731.c @@ -186,14 +186,12 @@ static int at91sam9g20ek_audio_probe(struct platform_device *pdev) return ret; } -static int at91sam9g20ek_audio_remove(struct platform_device *pdev) +static void at91sam9g20ek_audio_remove(struct platform_device *pdev) { struct snd_soc_card *card = platform_get_drvdata(pdev); snd_soc_unregister_card(card); atmel_ssc_put_audio(0); - - return 0; } #ifdef CONFIG_OF @@ -210,7 +208,7 @@ static struct platform_driver at91sam9g20ek_audio_driver = { .of_match_table = of_match_ptr(at91sam9g20ek_wm8731_dt_ids), }, .probe = at91sam9g20ek_audio_probe, - .remove = at91sam9g20ek_audio_remove, + .remove_new = at91sam9g20ek_audio_remove, }; module_platform_driver(at91sam9g20ek_audio_driver);