From patchwork Wed Mar 15 15:05:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13176140 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D4E7C61DA4 for ; Wed, 15 Mar 2023 15:24:02 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1737E1311; Wed, 15 Mar 2023 16:23:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1737E1311 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678893840; bh=FOfIj2pV04aWWA4gsQJnB0qF0b40DO1206/6g6bNZSk=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=FHnTylpX44rXqI+u4nMZEEll25VnhfTo2O8uXwOlIvyPjRtxOvLucTAT9nMve64Ov iIdpYRUZ2tVfHnFX6U6Z0hThTcGXvcF8pdZZvWp2HB6jhAC7LymToQ6FFooPDUz2xS 8wSbFINvcPVaQeZtH3vtNNz1vZRsd8y+3W+yUliA= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id C082DF8068C; Wed, 15 Mar 2023 16:11:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AEA5BF8016C; Wed, 15 Mar 2023 16:09:13 +0100 (CET) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 186F6F8016C for ; Wed, 15 Mar 2023 16:08:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 186F6F8016C Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcSjX-0007Ry-HI; Wed, 15 Mar 2023 16:08:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pcSjV-004KWa-Uw; Wed, 15 Mar 2023 16:08:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pcSjU-0057eJ-W5; Wed, 15 Mar 2023 16:08:05 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Ray Jui , Scott Branden , Charles Keepax , Allison Randal , Greg Kroah-Hartman , Thomas Gleixner Subject: [PATCH 039/173] ASoC: bcm: cygnus-ssp: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 16:05:31 +0100 Message-Id: <20230315150745.67084-40-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1591; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=FOfIj2pV04aWWA4gsQJnB0qF0b40DO1206/6g6bNZSk=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkEd2dv2+30yy3xC9w/q2zfPFOMQd5kFNUcn8zh fp26fHKbxiJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZBHdnQAKCRDB/BR4rcrs CRwcB/9RmUFA62/bGJzNSzRta91M19j8ABIiM7A7CU/afcE4Yv/PX7dqULvsmf5GWFXk1uVQ/t6 U8wFz9Fy0PISZk3ZGMbqfLE71K6VljaMZDX2nimifDq1Yy7yIrR1fEJRr4n9sbF4+uwyY1+vW9f Arh0MBDD4Oi2E7UGR5pp9q+VxxQQneM5iZ+awEHwI+XJbb4ciEwI0B2RNMY/XJcauhAQwyfR/x/ 1J9I7rDC7rySKOa1aa82OSMtMXaEooLvRQObgqB08fKzd49Auz1AyPbwh5kvKBqM/dvZo41r9Ww CzC8UclNEOix56m5fKLyJx//A7MizepNQttqy5vIGhgVzdam X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Message-ID-Hash: BMYNIRU6BVDBWMJDH7QIJW2BF7PSMVGF X-Message-ID-Hash: BMYNIRU6BVDBWMJDH7QIJW2BF7PSMVGF X-MailFrom: ukl@pengutronix.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Broadcom internal kernel review list , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- sound/soc/bcm/cygnus-ssp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/bcm/cygnus-ssp.c b/sound/soc/bcm/cygnus-ssp.c index 2a92e33e1fbf..8638bf22ef5c 100644 --- a/sound/soc/bcm/cygnus-ssp.c +++ b/sound/soc/bcm/cygnus-ssp.c @@ -1377,11 +1377,9 @@ static int cygnus_ssp_probe(struct platform_device *pdev) return 0; } -static int cygnus_ssp_remove(struct platform_device *pdev) +static void cygnus_ssp_remove(struct platform_device *pdev) { cygnus_soc_platform_unregister(&pdev->dev); - - return 0; } static const struct of_device_id cygnus_ssp_of_match[] = { @@ -1392,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, cygnus_ssp_of_match); static struct platform_driver cygnus_ssp_driver = { .probe = cygnus_ssp_probe, - .remove = cygnus_ssp_remove, + .remove_new = cygnus_ssp_remove, .driver = { .name = "cygnus-ssp", .of_match_table = cygnus_ssp_of_match,