From patchwork Wed Mar 15 15:05:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13176143 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC08AC6FD1D for ; Wed, 15 Mar 2023 15:24:48 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 59A231329; Wed, 15 Mar 2023 16:23:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 59A231329 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678893886; bh=P6/FN5pmayrY5xsPCXVGy0CqO6rObzGCLEanUtDVatU=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=kvA7gsLq9lIE5H2UI63Z/wqkBLVixGz6zBP6BKX+kKyoSBmpxu/02w/G8VA/p4dk9 lG9iFhtViKmZ+ETkiy4EX5wm55c9TF62p1Zyq4/FxRQibUEOpf/4Q6H5t5RKKen0/z JCoLCry68MnNc+0c7xtQXTaIWqik2rOmCT1DQMbs= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 03133F8069C; Wed, 15 Mar 2023 16:11:56 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 180FFF8065D; Wed, 15 Mar 2023 16:09:18 +0100 (CET) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 31288F80529 for ; Wed, 15 Mar 2023 16:08:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 31288F80529 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcSjc-0007ZG-4v; Wed, 15 Mar 2023 16:08:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pcSja-004KY3-Io; Wed, 15 Mar 2023 16:08:10 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pcSjZ-0057fb-GF; Wed, 15 Mar 2023 16:08:09 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Charles Keepax , Marek Szyprowski Subject: [PATCH 059/173] ASoC: codecs: wm8994: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 16:05:51 +0100 Message-Id: <20230315150745.67084-60-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1467; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=P6/FN5pmayrY5xsPCXVGy0CqO6rObzGCLEanUtDVatU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkEd3fBy2tC6E0FTTEu6TysZrodYqmgvXN8jpDk DRRcrYcGtSJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZBHd3wAKCRDB/BR4rcrs CYQxB/4vpv5dWZm0syhBfT2Y0T8Dge+aLId5XZD3mt0XV/bLbzFkbmRVIxeIdVxaWXNvK2zQMab iSzLjRepaFjLWFGx1GwP+Po0RN0rn1heIPP35GOpM8eANKRyBoGht8bMdotXIMDRwLSKxWlfeeL RXRhGTMkUvNqovlhs80bUU5ahrt+L3gYKhqXfUlMOiDQTrErp5FL+9YHPeiqtzgrLLUfLNlAX+e 3wDiLNCBrUj2Irz3mcRzecV8mSQLqZd0+G0FbfCeKsAj8Nhhdghx9KCTApuB9wXDh9GV4k9cHko MhyXEYSOH52xuv0cnke4JRjZRPIOXj8y0FoPyeVbd+CuxGbU X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Message-ID-Hash: RQFL6VOVCAR5Z5NGB44EBI6GEFDBR5BN X-Message-ID-Hash: RQFL6VOVCAR5Z5NGB44EBI6GEFDBR5BN X-MailFrom: ukl@pengutronix.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: patches@opensource.cirrus.com, alsa-devel@alsa-project.org, kernel@pengutronix.de X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Charles Keepax --- sound/soc/codecs/wm8994.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c index 8fe9a75d1235..bca3ebe0dac4 100644 --- a/sound/soc/codecs/wm8994.c +++ b/sound/soc/codecs/wm8994.c @@ -4657,11 +4657,9 @@ static int wm8994_probe(struct platform_device *pdev) return ret; } -static int wm8994_remove(struct platform_device *pdev) +static void wm8994_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -4701,7 +4699,7 @@ static struct platform_driver wm8994_codec_driver = { .pm = &wm8994_pm_ops, }, .probe = wm8994_probe, - .remove = wm8994_remove, + .remove_new = wm8994_remove, }; module_platform_driver(wm8994_codec_driver);