| Message ID | 20230317063338.18029-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: drivers: Remove the unused variable portman_read_data | expand |
On Fri, 17 Mar 2023 07:33:38 +0100, Jiapeng Chong wrote: > > Variable portman_read_data is not effectively used, so delete it. > > sound/drivers/portman2x4.c:195:18: warning: unused function 'portman_read_data'. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4557 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Thanks, applied now. Takashi
On Sun, 19 Mar 2023 09:06:05 +0100, Takashi Iwai wrote: > > On Fri, 17 Mar 2023 07:33:38 +0100, > Jiapeng Chong wrote: > > > > Variable portman_read_data is not effectively used, so delete it. > > > > sound/drivers/portman2x4.c:195:18: warning: unused function 'portman_read_data'. > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4557 > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > Thanks, applied now. ... and now I see Tom's patch removing one more unused one, so I took Tom's fix instead of yours. https://lore.kernel.org/r/20230318135229.1685266-1-trix@redhat.com thanks, Takashi
diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c index 52a656735365..41b46f9ae731 100644 --- a/sound/drivers/portman2x4.c +++ b/sound/drivers/portman2x4.c @@ -192,11 +192,6 @@ static inline u8 portman_read_status(struct portman *pm) return parport_read_status(pm->pardev->port); } -static inline u8 portman_read_data(struct portman *pm) -{ - return parport_read_data(pm->pardev->port); -} - static inline void portman_write_data(struct portman *pm, u8 value) { parport_write_data(pm->pardev->port, value);
Variable portman_read_data is not effectively used, so delete it. sound/drivers/portman2x4.c:195:18: warning: unused function 'portman_read_data'. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4557 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- sound/drivers/portman2x4.c | 5 ----- 1 file changed, 5 deletions(-)