diff mbox series

ALSA: hda: patch_realtek: add quirk for Asus N7601ZM

Message ID 20230406152725.15191-1-pierre-louis.bossart@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series ALSA: hda: patch_realtek: add quirk for Asus N7601ZM | expand

Commit Message

Pierre-Louis Bossart April 6, 2023, 3:27 p.m. UTC 
Add pins and verbs needed to enable speakers and jack.

The pins and verbs configurations were identified by snooping the
Windows driver commands, with a nice write-up here:
https://brakkee.org/site/2023/02/07/fixing-sound-on-the-asus-n7601zm/

Reported-by: Erik Brakkee <erik@brakkee.org>
Tested-by: Erik Brakkee <erik@brakkee.org>
Link: https://github.com/thesofproject/linux/issues/4176
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
 sound/pci/hda/patch_realtek.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

Comments

Takashi Iwai April 6, 2023, 3:38 p.m. UTC | #1 
On Thu, 06 Apr 2023 17:27:25 +0200,
Pierre-Louis Bossart wrote:
> 
> Add pins and verbs needed to enable speakers and jack.
> 
> The pins and verbs configurations were identified by snooping the
> Windows driver commands, with a nice write-up here:
> https://brakkee.org/site/2023/02/07/fixing-sound-on-the-asus-n7601zm/
> 
> Reported-by: Erik Brakkee <erik@brakkee.org>
> Tested-by: Erik Brakkee <erik@brakkee.org>
> Link: https://github.com/thesofproject/linux/issues/4176
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>

Applied now with a minor correction of the entry (to be sorted in SSID
order).


thanks,

Takashi
Pierre-Louis Bossart April 19, 2023, 7:23 p.m. UTC | #2 
Hi Takashi,

On 4/6/23 10:38, Takashi Iwai wrote:
> On Thu, 06 Apr 2023 17:27:25 +0200,
> Pierre-Louis Bossart wrote:
>>
>> Add pins and verbs needed to enable speakers and jack.
>>
>> The pins and verbs configurations were identified by snooping the
>> Windows driver commands, with a nice write-up here:
>> https://brakkee.org/site/2023/02/07/fixing-sound-on-the-asus-n7601zm/
>>
>> Reported-by: Erik Brakkee <erik@brakkee.org>
>> Tested-by: Erik Brakkee <erik@brakkee.org>
>> Link: https://github.com/thesofproject/linux/issues/4176
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
>> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> 
> Applied now with a minor correction of the entry (to be sorted in SSID
> order).

Apologies if I am missing something but I don't see this patch being
applied on the for-next/ branch?

Thanks,
-Pierre
Takashi Iwai April 26, 2023, 7:24 a.m. UTC | #3 
On Wed, 19 Apr 2023 21:23:26 +0200,
Pierre-Louis Bossart wrote:
> 
> Hi Takashi,
> 
> On 4/6/23 10:38, Takashi Iwai wrote:
> > On Thu, 06 Apr 2023 17:27:25 +0200,
> > Pierre-Louis Bossart wrote:
> >>
> >> Add pins and verbs needed to enable speakers and jack.
> >>
> >> The pins and verbs configurations were identified by snooping the
> >> Windows driver commands, with a nice write-up here:
> >> https://brakkee.org/site/2023/02/07/fixing-sound-on-the-asus-n7601zm/
> >>
> >> Reported-by: Erik Brakkee <erik@brakkee.org>
> >> Tested-by: Erik Brakkee <erik@brakkee.org>
> >> Link: https://github.com/thesofproject/linux/issues/4176
> >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> >> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> >> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> > 
> > Applied now with a minor correction of the entry (to be sorted in SSID
> > order).
> 
> Apologies if I am missing something but I don't see this patch being
> applied on the for-next/ branch?

It was in for-linus branch and already merged in Linus tree for 6.3
final in commit e959f2beec8e655dba79c5a7111beedae5e757e0.

Currently my for-next and for-linus branches are diverged.
Will be merged back once after 6.4-rc1 merge window is closed.


thanks,

Takashi
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b501f9489fc1..2baeb6efbdc7 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6959,6 +6959,8 @@  enum {
 	ALC269_FIXUP_DELL_M101Z,
 	ALC269_FIXUP_SKU_IGNORE,
 	ALC269_FIXUP_ASUS_G73JW,
+	ALC269_FIXUP_ASUS_N7601ZM_PINS,
+	ALC269_FIXUP_ASUS_N7601ZM,
 	ALC269_FIXUP_LENOVO_EAPD,
 	ALC275_FIXUP_SONY_HWEQ,
 	ALC275_FIXUP_SONY_DISABLE_AAMIX,
@@ -7255,6 +7257,29 @@  static const struct hda_fixup alc269_fixups[] = {
 			{ }
 		}
 	},
+	[ALC269_FIXUP_ASUS_N7601ZM_PINS] = {
+		.type = HDA_FIXUP_PINS,
+		.v.pins = (const struct hda_pintbl[]) {
+			{ 0x19, 0x03A11050 },
+			{ 0x1a, 0x03A11C30 },
+			{ 0x21, 0x03211420 },
+			{ }
+		}
+	},
+	[ALC269_FIXUP_ASUS_N7601ZM] = {
+		.type = HDA_FIXUP_VERBS,
+		.v.verbs = (const struct hda_verb[]) {
+			{0x20, AC_VERB_SET_COEF_INDEX, 0x62},
+			{0x20, AC_VERB_SET_PROC_COEF, 0xa007},
+			{0x20, AC_VERB_SET_COEF_INDEX, 0x10},
+			{0x20, AC_VERB_SET_PROC_COEF, 0x8420},
+			{0x20, AC_VERB_SET_COEF_INDEX, 0x0f},
+			{0x20, AC_VERB_SET_PROC_COEF, 0x7774},
+			{ }
+		},
+		.chained = true,
+		.chain_id = ALC269_FIXUP_ASUS_N7601ZM_PINS,
+	},
 	[ALC269_FIXUP_LENOVO_EAPD] = {
 		.type = HDA_FIXUP_VERBS,
 		.v.verbs = (const struct hda_verb[]) {
@@ -9485,6 +9510,7 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1043, 0x19ce, "ASUS B9450FA", ALC294_FIXUP_ASUS_HPE),
 	SND_PCI_QUIRK(0x1043, 0x19e1, "ASUS UX581LV", ALC295_FIXUP_ASUS_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
+	SND_PCI_QUIRK(0x1043, 0x12a3, "Asus N7691ZM", ALC269_FIXUP_ASUS_N7601ZM),
 	SND_PCI_QUIRK(0x1043, 0x1a30, "ASUS X705UD", ALC256_FIXUP_ASUS_MIC),
 	SND_PCI_QUIRK(0x1043, 0x1a8f, "ASUS UX582ZS", ALC245_FIXUP_CS35L41_SPI_2),
 	SND_PCI_QUIRK(0x1043, 0x1b11, "ASUS UX431DA", ALC294_FIXUP_ASUS_COEF_1B),