| Message ID | 20230505073813.1219175-5-perex@perex.cz (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 190cb66a4ee0ac4419e1f8a9de46074a8c8e4c23 |
| Headers | show |
| Series | rewrite snd_pcm_playback_silence() again | expand |
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index cfdb4aa5f6fa..952f0d807124 100644 --- a/sound/core/pcm_lib.c +++ b/sound/core/pcm_lib.c @@ -61,8 +61,6 @@ void snd_pcm_playback_silence(struct snd_pcm_substream *substream, snd_pcm_ufram runtime->silence_filled = 0; runtime->silence_start = appl_ptr; } - if (runtime->silence_filled >= runtime->buffer_size) - return; /* initialization outside pointer updates */ if (new_hw_ptr == ULONG_MAX) new_hw_ptr = runtime->status->hw_ptr;
The removed condition handles de facto only one situation where runtime->silence_filled variable is equal to runtime->buffer_size, because this variable cannot go over the buffer size. This case is catched also with the next condition for the noise distance and required threshold comparison. Suggested-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Signed-off-by: Jaroslav Kysela <perex@perex.cz> --- sound/core/pcm_lib.c | 2 -- 1 file changed, 2 deletions(-)