From patchwork Fri Jun 30 14:27:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 13299724 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEF8CC0015E for ; Mon, 3 Jul 2023 08:35:07 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3D890843; Mon, 3 Jul 2023 10:34:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3D890843 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1688373305; bh=PQzafQPINWzNCKfU5qAbB7q39zv1fe5dtlRulHQmlWU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=EaxtjIwBnQzRYXAGE90rN+WWqTJXqJnhQvqathlgLdiT2rBgeWIUrrLfFAz9eye8Q Wx/Juv1UM1YH2BWWW5c9eh1sgxeyC2/Yakl/1XgEBrtZMLmvjAEPS8JtCcOi/hVmn1 de9xC1PPXXKZ7EskQTk5yTutQ09tbGH1VWChr0RY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id DDEC5F805B5; Mon, 3 Jul 2023 10:32:36 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 35584F805B3; Mon, 3 Jul 2023 10:32:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 81B7FF80431; Fri, 30 Jun 2023 16:27:32 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AAE56F80246 for ; Fri, 30 Jun 2023 16:27:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AAE56F80246 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=EEH5d8nm Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 45E1961758; Fri, 30 Jun 2023 14:27:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB908C433CA; Fri, 30 Jun 2023 14:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688135238; bh=PQzafQPINWzNCKfU5qAbB7q39zv1fe5dtlRulHQmlWU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EEH5d8nmZCFHaRW8Qfwvrw5eNUf+1b2fNeJWl2yEjsEaYvYJH0AzcfYcAfP2rHAe7 sBLFMDTvsOaXYOYCudL0iFFfRwKwwgEXgrlXqC4nG23beyJK+aJUOXQInbZy20Tle5 3YUWnL39h1Q68uJzcvO+S1WxjG+0y392YKXRo15u8y2hZOIFBW06lIlUlIb2LG2IQ9 W66LzIPVxrsK2xDEh2qvjNdaP89h+TF+u9CzC9JRo7aRyQS0XBnFMVTYed/WyuGWvY z+I1c8vDDYWSksfECI0r9E/HS6Sk+9WKQ4ZbhU2M8AVAK243u3Gkw4DgxlGC3YjOaz uQ4eGCn4tJXjw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qFF5p-0001OQ-BJ; Fri, 30 Jun 2023 16:27:25 +0200 From: Johan Hovold To: Mark Brown , Srinivas Kandagatla Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 2/5] ASoC: codecs: wcd938x: drop inline keywords Date: Fri, 30 Jun 2023 16:27:14 +0200 Message-Id: <20230630142717.5314-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230630142717.5314-1-johan+linaro@kernel.org> References: <20230630142717.5314-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-MailFrom: johan+linaro@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: UZF3MPPX3GIOVAWAD4CG3F5ICPAYGK7H X-Message-ID-Hash: UZF3MPPX3GIOVAWAD4CG3F5ICPAYGK7H X-Mailman-Approved-At: Mon, 03 Jul 2023 08:32:29 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The compiler is generally better at deciding what functions should be inlined than driver authors are. Drop the bogus inline keyword from two functions that were neither very small or used in a single place. Signed-off-by: Johan Hovold --- sound/soc/codecs/wcd938x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index b8a52a1a63d5..5ce15b622a91 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -2124,7 +2124,7 @@ static int wcd938x_mbhc_micb_ctrl_threshold_mic(struct snd_soc_component *compon return wcd938x_mbhc_micb_adjust_voltage(component, micb_mv, MIC_BIAS_2); } -static inline void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd938x, +static void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd938x, s16 *d1_a, u16 noff, int32_t *zdet) { @@ -2231,8 +2231,8 @@ static void wcd938x_mbhc_zdet_ramp(struct snd_soc_component *component, *zr = zdet; } -static inline void wcd938x_wcd_mbhc_qfuse_cal(struct snd_soc_component *component, - int32_t *z_val, int flag_l_r) +static void wcd938x_wcd_mbhc_qfuse_cal(struct snd_soc_component *component, + int32_t *z_val, int flag_l_r) { s16 q1; int q1_cal;