From patchwork Sat Jul 8 02:52:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 13305576 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DABCEB64DA for ; Sat, 8 Jul 2023 05:18:05 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 37F23741; Sat, 8 Jul 2023 07:17:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 37F23741 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1688793483; bh=+q+SHeAkpu0eBC3ZekM3sERLBUwjrTX8kgXFikTCAkE=; h=From:To:CC:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=Nj9DcNRz7J04xavIt1STAd5sIaTwJGmPWB+nR2fIqlPO2QhnycJapsrercT3hdi6i uEn4ir0O5yAattywG9J/8BrdrNQH7e6PRTEsPTdW2dL/c1WFla7EYEep7t4JCiVFNv nbGYRjqKVnPUEqb1Tq5BMLY4tYIzRFlfFtbp7/UY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 53928F80153; Sat, 8 Jul 2023 07:16:45 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 5AA9FF80125; Sat, 8 Jul 2023 07:16:45 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 12C69F80125; Sat, 8 Jul 2023 07:11:41 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2060a.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e8c::60a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BD736F80104 for ; Sat, 8 Jul 2023 07:11:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BD736F80104 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=4W7cFyWO ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Na4MrHjU4VWguws25sygKQRrLtTx7HFnqc9w4fzZmcbdynOF9oAAJ7dA23rFca0nr+SmSHgsbb/kKHkEztN6759CfXZ3YL3qApx2oGBdPi+5/MvTITSup6SxaU5MJy0GrfkuwHFTmUWesT4xk2a52mG3OLAD5MTCLr/bCvLoexN/CKxe2l1lvwNakKDGWDc9stTdyckD1OX4ctAndYQO1lYIVeKquQVieio9FTz+mLyDLCnOQUCzWN02BDNOd4wfMBOH627h2hmETEaqt3tEtIWRxgbp3iTQDiOoFMmt94jmwayKNhYe7y9xV+hTge31gVFUy+8EgfqZItBktaskaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y5Dnu9iQZyuAdIIXTmz8i9e3lYvip75UtZfFO6Xdr0s=; b=l3DAiK78tVTawOTBv4smQTaJFzx5Qb8V24MsinZkcvFhAe7vdVaEqB3EcaImAbaU9NCosCxc5OzfXOHhvO+ipYfTmzovhMz+WNKRYzuyYD/AqcddyO2pqDiDR762ybJ/W8DfG/NgdfBI082HTknoO7nfFLWbhwgOLLNLlfthS0Zfc2UQxUNuAto/brc/Q7bkGYgr761SGBkuK0rQTSseFaQ2qcPAva/77An64AfNv0+VCaHKc19ux3V0g/fVTo+8LyGMPOWFl77V2gOUeqxvkWUirKjtDYo8RlZd1OIYVrlW4Ylzojjmabk6MIMJapLaa8egsOPaMxCdhLwTHEavDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y5Dnu9iQZyuAdIIXTmz8i9e3lYvip75UtZfFO6Xdr0s=; b=4W7cFyWOiImw5V/4vFqfpxmaa7yMVMnYQRHSfkxZIBfQZNeqJcDvbsmY6F/odt+UCTPTLRq0M/qZqKTiyj5nUv5hSdmmxPb+2CigrlW17jb31FlJ+X4Ijj56LUkwuNETM4f7MU6kCwMpTCvfy+0DqpHoFA7olHD3uZxegn3PL3M= Received: from BN0PR02CA0033.namprd02.prod.outlook.com (2603:10b6:408:e5::8) by MW4PR12MB6976.namprd12.prod.outlook.com (2603:10b6:303:20a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.25; Sat, 8 Jul 2023 05:11:15 +0000 Received: from BN8NAM11FT113.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e5:cafe::3b) by BN0PR02CA0033.outlook.office365.com (2603:10b6:408:e5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.26 via Frontend Transport; Sat, 8 Jul 2023 05:11:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT113.mail.protection.outlook.com (10.13.176.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6544.30 via Frontend Transport; Sat, 8 Jul 2023 05:11:14 +0000 Received: from SITE-L-T34-2.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sat, 8 Jul 2023 00:11:06 -0500 From: Mario Limonciello To: , , , CC: , , "Mario Limonciello" Subject: [PATCH] ASoC: amd: ps: Fix extraneous error messages Date: Fri, 7 Jul 2023 21:52:08 -0500 Message-ID: <20230708025208.54272-1-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT113:EE_|MW4PR12MB6976:EE_ X-MS-Office365-Filtering-Correlation-Id: d92ab2a2-31d2-45d0-3d97-08db7f71c10b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s/DvUEjAg4opJ7AcfxJ9Jpv/pXXfTFVBsnTOljCfguOTu0KCNdbCP5kzOppW0q22QIb9fZZRmS1gU+v8IL1Izmqe6P+ddeK3hP5LDAU38FPIPNFZmz4VRZ7vKia6rEnQ8LwCo/c2eF7G7u5rINvp931w+oB3QfiLyogQIKsnLO498h88XmA7Exzs8Dl2FX/BPqKvOw9K9GiuO0cW/D3ckBtkQXUdB7vuCvYqoAVG/IgL1kqTT0WQTiv3rSEEWb4vWXKGqlPZSZLwq00WtsXahYSoB3TwOCZNBMk2+qRjeimi5118mm9skR0EnGiZ+9kCfdcPUfS1BZ21WNiP1EFEJ919smife7cnnxMReQY0d5drMplEoLDRt6yamuWbqYP/ILkAIcGFRnZde8dZQ6TD9BUFEAmduL9sN6ZKf2/QQXCJFM7qG9PNCCzzQFSw1HLb3+r9Z6VO65mVvrFUJspqsxl5JCfSm8ixpnoyqa+Pveyw+d8p6qe06BS92vR/MSqf+54rFGRt2cuQXkLMwEMscUISpo15EA13IEG01uWGtKdRyBlNz3wfGaPimVceWHX/zP+VGilA9ergQm//ZIHZ8v3B+wy8UG8PYsS2bQhvLvD7mchZpEe7A1HccqXimVnqzebjx9AHchG5n+eNh41T0Dx4z59LrX4he/XkAnyoYYBjA/aVcQqWEW+CCdPpBQGaqfRISgRqPH8hAVK0AaTlNrjNj5e06nGc4Cy8MqWSOCZSZoDQavUsWzd0YNzklAbhcntpnK+koCC3FFMV/vPGWw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199021)(46966006)(40470700004)(36840700001)(2906002)(82310400005)(356005)(40460700003)(81166007)(82740400003)(426003)(47076005)(83380400001)(26005)(40480700001)(2616005)(186003)(7696005)(36860700001)(5660300002)(336012)(1076003)(16526019)(86362001)(8676002)(15650500001)(44832011)(36756003)(110136005)(54906003)(478600001)(4326008)(6636002)(70206006)(41300700001)(316002)(70586007)(8936002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2023 05:11:14.9516 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d92ab2a2-31d2-45d0-3d97-08db7f71c10b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT113.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6976 Message-ID-Hash: LBTQWRWXTY4KGBJRHWJVWKHBGLMDL3NS X-Message-ID-Hash: LBTQWRWXTY4KGBJRHWJVWKHBGLMDL3NS X-MailFrom: Mario.Limonciello@amd.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Pink Sardine machines that don't have SdW controllers in use, the property `mipi-sdw-manager-list` won't exist. There is no point in showing an error to a user when this situation is encountered. Furthermore if the machine doesn't have a DMIC connected to the ACP, there may be no platform devices created either. Downgrade the associated message to debug. Fixes: d1351c30ac8a6 ("ASoC: amd: ps: create platform devices based on acp config") Signed-off-by: Mario Limonciello --- sound/soc/amd/ps/pci-ps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 8689f4f2ea561dd080118eeb05c0255ac9542905 diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c index 5b46dc8573f86..4af3c3665387d 100644 --- a/sound/soc/amd/ps/pci-ps.c +++ b/sound/soc/amd/ps/pci-ps.c @@ -257,7 +257,7 @@ static int sdw_amd_scan_controller(struct device *dev) &sdw_manager_bitmap, 1); if (ret) { - dev_err(dev, "Failed to read mipi-sdw-manager-list: %d\n", ret); + dev_dbg(dev, "Failed to read mipi-sdw-manager-list: %d\n", ret); return -EINVAL; } count = hweight32(sdw_manager_bitmap); @@ -641,7 +641,7 @@ static int snd_acp63_probe(struct pci_dev *pci, ret = get_acp63_device_config(val, pci, adata); /* ACP PCI driver probe should be continued even PDM or SoundWire Devices are not found */ if (ret) { - dev_err(&pci->dev, "get acp device config failed:%d\n", ret); + dev_dbg(&pci->dev, "get acp device config failed:%d\n", ret); goto skip_pdev_creation; } ret = create_acp63_platform_devs(pci, adata, addr);