| Message ID | 20230718-asoc-topology-kunit-enable-v2-3-0ee11e662b92@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 512d092d78823f9813f4af38090b33c454137a4c |
| Headers | show |
| Series | ASoC: Improve coverage in default KUnit runs | expand |
On Tue, 18 Jul 2023 at 08:30, Mark Brown <broonie@kernel.org> wrote: > > In order to facilitate testing using KUnit allow ALSA to build with UML, > it's not super useful at runtime but that's a user problem rather than > an actual dependency. The apparent reason for the dependency was the > widespread use of iomem APIs in ALSA drivers, earlier patches in this > series have provided stubs for these APIs so that there are no build > time issues even without individual drivers having IOMEM dependencies > added. > > Signed-off-by: Mark Brown <broonie@kernel.org> > --- This works well here, and I'd love to see it go through. I'll leave it to the ALSA folks in case there are other issues with UML they're worried about, though. Tested-by: David Gow <davidgow@google.com> Cheers, -- David > sound/Kconfig | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/sound/Kconfig b/sound/Kconfig > index 0ddfb717b81d..f0e15822e858 100644 > --- a/sound/Kconfig > +++ b/sound/Kconfig > @@ -39,8 +39,6 @@ config SOUND_OSS_CORE_PRECLAIM > > source "sound/oss/dmasound/Kconfig" > > -if !UML > - > menuconfig SND > tristate "Advanced Linux Sound Architecture" > help > @@ -103,8 +101,6 @@ source "sound/virtio/Kconfig" > > endif # SND > > -endif # !UML > - > endif # SOUND > > config AC97_BUS > > -- > 2.39.2 >
diff --git a/sound/Kconfig b/sound/Kconfig index 0ddfb717b81d..f0e15822e858 100644 --- a/sound/Kconfig +++ b/sound/Kconfig @@ -39,8 +39,6 @@ config SOUND_OSS_CORE_PRECLAIM source "sound/oss/dmasound/Kconfig" -if !UML - menuconfig SND tristate "Advanced Linux Sound Architecture" help @@ -103,8 +101,6 @@ source "sound/virtio/Kconfig" endif # SND -endif # !UML - endif # SOUND config AC97_BUS
In order to facilitate testing using KUnit allow ALSA to build with UML, it's not super useful at runtime but that's a user problem rather than an actual dependency. The apparent reason for the dependency was the widespread use of iomem APIs in ALSA drivers, earlier patches in this series have provided stubs for these APIs so that there are no build time issues even without individual drivers having IOMEM dependencies added. Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/Kconfig | 4 ---- 1 file changed, 4 deletions(-)