From patchwork Thu Sep 7 17:10:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Ciocaltea X-Patchwork-Id: 13376683 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C961EC8743 for ; Thu, 7 Sep 2023 17:12:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 16C40A4B; Thu, 7 Sep 2023 19:11:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 16C40A4B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1694106729; bh=qbGf9dTskivmBZH5bu+AEo0oFeT7I13FlT9OFQJZyls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=NJ269Mjb0ed/ckac0/Cf8Px818ItnxTwjkY24skXUn53eaTzmZ/EUW3F/M/4cBdZM AEAxo6loQu0BjytXjn6041+XGuKoVVHizk+lfOfPD9VSYEKtcgBRa+HI72YktqOdFc VpnFNh+iygSCpEdl5uvWx8Nu69vj7998Vk/7opWE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 07658F80571; Thu, 7 Sep 2023 19:10:30 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 5CAC2F80552; Thu, 7 Sep 2023 19:10:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DBF40F804F3; Thu, 7 Sep 2023 19:10:24 +0200 (CEST) Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 161F5F8047D for ; Thu, 7 Sep 2023 19:10:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 161F5F8047D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=mail header.b=LQRBunHi Received: from localhost (unknown [81.18.92.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id EA96166072BA; Thu, 7 Sep 2023 18:10:17 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1694106618; bh=qbGf9dTskivmBZH5bu+AEo0oFeT7I13FlT9OFQJZyls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LQRBunHiDczrq43E+clWbn9RMyk+/WWLK3X5J7sAsRcgFttDr3Ng4pVKVpuS7U9Lg cERBQmBbo339i5OHr0Te8p6KuQCQb4MyFC8ApnCmoCJgwJ70F97SYkJ7rFKuRxINAP YzBqEn96OpxRqKUkMjdCboFagVqs8swhC+BMzdEpjixlGPZwGhHvB7XPHeesThRRMI I0xa1j8ddKYC+WAhm55RuQH9ZJKlRPWFE6I3043dWJA/aBb7wG95rg5g1QVsxoaG2k lRDVuqkeskvbQsMSvtzIUdXmYUCyWNwnfhvTWyCXV5+6+AR+VyLfXrqH82dSDRUG0L W4gsFq7wS8/nQ== From: Cristian Ciocaltea To: James Schulman , David Rhodes , Richard Fitzgerald , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Stefan Binding , Charles Keepax , Vitaly Rodionov Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: [PATCH v2 01/11] ASoC: cs35l41: Handle mdsync_down reg write errors Date: Thu, 7 Sep 2023 20:10:00 +0300 Message-ID: <20230907171010.1447274-2-cristian.ciocaltea@collabora.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230907171010.1447274-1-cristian.ciocaltea@collabora.com> References: <20230907171010.1447274-1-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 Message-ID-Hash: LBJZ5NUC5GPHGXTRWB53EEQYEMRSTDNA X-Message-ID-Hash: LBJZ5NUC5GPHGXTRWB53EEQYEMRSTDNA X-MailFrom: cristian.ciocaltea@collabora.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The return code of regmap_multi_reg_write() call related to "MDSYNC down" sequence is shadowed by the subsequent wait_for_completion_timeout() invocation, which is expected to time timeout in case the write operation failed. Let cs35l41_global_enable() return the correct error code instead of -ETIMEDOUT. Fixes: f5030564938b ("ALSA: cs35l41: Add shared boost feature") Signed-off-by: Cristian Ciocaltea Acked-by: Charles Keepax --- sound/soc/codecs/cs35l41-lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs35l41-lib.c b/sound/soc/codecs/cs35l41-lib.c index 4ec306cd2f47..a018f1d98428 100644 --- a/sound/soc/codecs/cs35l41-lib.c +++ b/sound/soc/codecs/cs35l41-lib.c @@ -1243,7 +1243,7 @@ int cs35l41_global_enable(struct device *dev, struct regmap *regmap, enum cs35l4 cs35l41_mdsync_down_seq[2].def = pwr_ctrl1; ret = regmap_multi_reg_write(regmap, cs35l41_mdsync_down_seq, ARRAY_SIZE(cs35l41_mdsync_down_seq)); - if (!enable) + if (ret || !enable) break; if (!pll_lock)