| Message ID | 20230914140852.7112-1-rf@opensource.cirrus.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: hda: cs35l56: Don't 'return ret' if ret is always zero | expand |
On Thu, 14 Sep 2023 16:08:52 +0200, Richard Fitzgerald wrote: > > The final return in cs35l56_hda_posture_get() was returning the > value of 'ret', but ret is always zero at this point. So this > can be a simple 'return 0'. > > Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Thanks, applied. Takashi
diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c index a9844336bdc9..c64600280f02 100644 --- a/sound/pci/hda/cs35l56_hda.c +++ b/sound/pci/hda/cs35l56_hda.c @@ -216,11 +216,11 @@ static int cs35l56_hda_posture_get(struct snd_kcontrol *kcontrol, if (ret) return ret; ucontrol->value.integer.value[0] = pos; - return ret; + return 0; } static int cs35l56_hda_posture_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) {
The final return in cs35l56_hda_posture_get() was returning the value of 'ret', but ret is always zero at this point. So this can be a simple 'return 0'. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> --- sound/pci/hda/cs35l56_hda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)