From patchwork Wed Sep 20 09:03:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 13392347 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27302CE79AC for ; Wed, 20 Sep 2023 09:05:42 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 75B48206; Wed, 20 Sep 2023 11:04:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 75B48206 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1695200740; bh=fO32P0+z8LQ2zu1di2mv+Du/u4oPYdW+ceregpvLAEs=; h=From:To:CC:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=qzWOEutfXsg4teQSmkVQjzFzEPnkwHNMEyuRBdRvoyLulbfZZKdwGO9oihnbw4btF 70kQFsL3rmbDkAdj/yHAMsQongU5efdi6Knsdv0HMs/f3GCthFUTzFLt1kBMxkTc5C gpoygtpHCpkgv/sppSLSaw8VkhHFP59AOeKqrloE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 22BF5F8055A; Wed, 20 Sep 2023 11:04:22 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 9C0FAF8025A; Wed, 20 Sep 2023 11:04:21 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CAD51F8025A; Wed, 20 Sep 2023 11:04:17 +0200 (CEST) Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6CF28F800AA for ; Wed, 20 Sep 2023 11:03:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6CF28F800AA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=cirrus.com header.i=@cirrus.com header.a=rsa-sha256 header.s=PODMain02222019 header.b=hHpaLLuG Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 38K3GoSr018911; Wed, 20 Sep 2023 04:03:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=v Em9S6Wha8oGRe3mleV8+Gy4YEDfjz8SVmCnJA061Dw=; b=hHpaLLuGQLHxyjeS5 ZKQ2VhWfa7IdccTgbX8Cr05H+0NVvQ0NW8+J4ZQAuPS/k+v0FkVobzDuPGKBck+d T7yV74yxRea1DbmM0C/EgoRlnpVE5HE7otj7gOhWV8LDFmEHC5eTg93RscG6rJV5 zZXCe3kwq1SNw2PHEf6pswy4tV27BVrLepEPJVnRRIMfE1xh3334fAy31hUzrhc5 xG7eDrnAAnvgK+CvWprne+zAMec/pFRdeZHhCGvIgLlsrkJBpgEtF5ktqwPMTmCb xJ+s0jA0d1hu3JgSKOfjKehFzM8Uvs+QrcdWQwr+kYJNrKSgEhtag7jOUPuk4VWW Y6mvg== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3t59ry572h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Sep 2023 04:03:47 -0500 (CDT) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Wed, 20 Sep 2023 10:03:45 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Wed, 20 Sep 2023 10:03:45 +0100 Received: from EDIN4L06LR3.ad.cirrus.com (unknown [198.90.238.129]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 0FD0511AA; Wed, 20 Sep 2023 09:03:45 +0000 (UTC) From: Richard Fitzgerald To: CC: , , , Richard Fitzgerald , kernel test robot Subject: [PATCH] ALSA: hda: cirrus_scodec: Select GPIOLIB for KUnit test Date: Wed, 20 Sep 2023 10:03:38 +0100 Message-ID: <20230920090338.29345-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Proofpoint-GUID: _F5HLFKgPHp6ijuj-437vxI4GfFRzN4h X-Proofpoint-ORIG-GUID: _F5HLFKgPHp6ijuj-437vxI4GfFRzN4h X-Proofpoint-Spam-Reason: safe Message-ID-Hash: 6ZQWRLD2SAGH6V6A7NVBP2XMUDMIS5C4 X-Message-ID-Hash: 6ZQWRLD2SAGH6V6A7NVBP2XMUDMIS5C4 X-MailFrom: prvs=4627bb6ac3=rf@opensource.cirrus.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The KUnit test for cirrus_scodec uses GPIO library functions so select GPIOLIB in Kconfig. This fixes the ld failures on builds that didn't already select GPIOLIB. ld: vmlinux.o: in function `cirrus_scodec_test_gpio_get': sound/pci/hda/cirrus_scodec_test.c:40: undefined reference to `gpiochip_get_data' ld: vmlinux.o: in function `cirrus_scodec_test_gpio_probe': sound/pci/hda/cirrus_scodec_test.c:94: undefined reference to `gpiochip_generic_request' ld: sound/pci/hda/cirrus_scodec_test.c:94: undefined reference to `gpiochip_generic_free' ld: sound/pci/hda/cirrus_scodec_test.c:95: undefined reference to `devm_gpiochip_add_data_with_key' Signed-off-by: Richard Fitzgerald Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202309201646.NnjfKPWk-lkp@intel.com/ Fixes: 2144833e7b41 ("ALSA: hda: cirrus_scodec: Add KUnit test") --- sound/pci/hda/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig index 706cdc589e6f..21a90b3c4cc7 100644 --- a/sound/pci/hda/Kconfig +++ b/sound/pci/hda/Kconfig @@ -97,6 +97,7 @@ config SND_HDA_CIRRUS_SCODEC config SND_HDA_CIRRUS_SCODEC_KUNIT_TEST tristate "KUnit test for Cirrus side-codec library" if !KUNIT_ALL_TESTS select SND_HDA_CIRRUS_SCODEC + select GPIOLIB depends on KUNIT default KUNIT_ALL_TESTS help