diff mbox series

[6.4,6.5] ASoC: cs35l56: Disable low-power hibernation mode

Message ID 20230925151443.28956-1-rf@opensource.cirrus.com (mailing list archive)
State New, archived
Headers show
Series [6.4,6.5] ASoC: cs35l56: Disable low-power hibernation mode | expand

Commit Message

Richard Fitzgerald Sept. 25, 2023, 3:14 p.m. UTC 
commit 18789be8e0d9fbb78b2290dcf93f500726ed19f0 upstream.
Please apply to 6.4 and 6.5.

Do not allow the CS35L56 to be put into its lowest power
"hibernation" mode. This only affects I2C because "hibernation"
is already disabled on SPI and SoundWire.

Recent firmwares need a different wake-up sequence. Until
that sequence has been specified, the chip "hibernation" mode
must be disabled otherwise it can intermittently fail to wake.

Backport note: This is the same change as upstream commit, to delete
one line, but the upstream commit would not apply cleanly on older
branches because of minor differences to the surrounding code.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230912133841.3480466-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/cs35l56-i2c.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Sasha Levin Sept. 28, 2023, 11:47 a.m. UTC | #1 
On Mon, Sep 25, 2023 at 04:14:43PM +0100, Richard Fitzgerald wrote:
>commit 18789be8e0d9fbb78b2290dcf93f500726ed19f0 upstream.
>Please apply to 6.4 and 6.5.
>
>Do not allow the CS35L56 to be put into its lowest power
>"hibernation" mode. This only affects I2C because "hibernation"
>is already disabled on SPI and SoundWire.
>
>Recent firmwares need a different wake-up sequence. Until
>that sequence has been specified, the chip "hibernation" mode
>must be disabled otherwise it can intermittently fail to wake.
>
>Backport note: This is the same change as upstream commit, to delete
>one line, but the upstream commit would not apply cleanly on older
>branches because of minor differences to the surrounding code.

Queued up for 6.5. 6.4 is EOL.
diff mbox series

Patch

diff --git a/sound/soc/codecs/cs35l56-i2c.c b/sound/soc/codecs/cs35l56-i2c.c
index c613a2554fa3..494adabd4f43 100644
--- a/sound/soc/codecs/cs35l56-i2c.c
+++ b/sound/soc/codecs/cs35l56-i2c.c
@@ -27,7 +27,6 @@  static int cs35l56_i2c_probe(struct i2c_client *client)
 		return -ENOMEM;
 
 	cs35l56->dev = dev;
-	cs35l56->can_hibernate = true;
 
 	i2c_set_clientdata(client, cs35l56);
 	cs35l56->regmap = devm_regmap_init_i2c(client, regmap_config);