From patchwork Tue Oct 17 02:12:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Rau X-Patchwork-Id: 13424313 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DD52CDB465 for ; Tue, 17 Oct 2023 02:15:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7FAFF82B; Tue, 17 Oct 2023 04:14:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7FAFF82B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1697508937; bh=+2hy49LWW81JbScf8tK8NcSxzNRh9ynUnemUO3lwTSw=; h=From:To:Cc:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=DUhvOsIhPagUxAxE6nU5JJrq3Ti6JrpUHUI1tmhyo2qMp/2dp36d7ZC61MZrRHJjH SBUOW/KcoiYG1hw8tH9lNvN/msGhadtx8AaBDPYCGQDDZof9/wZ/4iS3imvJTsnH+L uJtFwDOIhwgm+ZNPwV3Jn65NR3W3IjGNnGsehIEw= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 26E47F8024E; Tue, 17 Oct 2023 04:14:16 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id ED9AAF8025F; Tue, 17 Oct 2023 04:14:15 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B0450F8025F; Tue, 17 Oct 2023 04:14:04 +0200 (CEST) Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01on2072e.outbound.protection.outlook.com [IPv6:2a01:111:f403:700c::72e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D95DFF80166 for ; Tue, 17 Oct 2023 04:13:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D95DFF80166 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=dm.renesas.com header.i=@dm.renesas.com header.a=rsa-sha256 header.s=selector1 header.b=N5f+sODt ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aY5BviUH0agEne/89W9E/vzpqodp0Vxb+3DOjWoEznRQfX3rgdIGmROKzLe2WNN78BJstbunzEU/L9Qyx5f6DWdaJS358ZZRMvi+FjaLEqvMVLk545IifYFbJ4+DqOR/wvIpzVMz2Y7HQ87/jLRPI9R6DvK5S7rHGXVIzcqSu1Oj2XkuIQouY5q0nk2fxzHG1gONNsboBNY+Gcatn3bdRnhAXLxYorCcgfRmcuwlwj726iuQUxrNh6lKKxN9iUVsgzc14NjVYj7QdelUaKBdGkKtkm4PEjD1Ahaa+wyc848q8jzY5Bn6NMBysyj7GLnznRmUr+R2O8Fz7pJk/4q4uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bXErV5f9JUHJbdriCKeJBzfvArRxBnbpG+8beFGrYqo=; b=kGBLGcAOT+lzMFBPZp4eE3DHiNjN2ukyPDr3xW5x8Us5kIbkLYT25Qo7A3tEglLo7jv08EfRV6Q06Ceh77OsKKEjBvLY/DKRO6yU+EnrXacbonTPBjm0tlgKAdjGzgy3LUPvg7SkVKfYrwAIiohxAGSLUJ7VXyZW1LMtcma5xaXvNqFB92LUOrK5ydB/H1YR1ltLx0hQR4u+cV2spYjGhHvMX8m5NMPc0+oaIGrS9pNTO/Tua61gOrRUwDLyboXZomlHERjVqnSsUYwGQmqdcOfqmFV5FmQJmgR3ZSad+mjf/ilNVxshCxsQCwTnGilcCDjDc6AdpCQpUgJwu4FHqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dm.renesas.com; dmarc=pass action=none header.from=dm.renesas.com; dkim=pass header.d=dm.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dm.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bXErV5f9JUHJbdriCKeJBzfvArRxBnbpG+8beFGrYqo=; b=N5f+sODt7NfIcR6saX/BO58rckMsuXK3F2IjvxOXR7jp0IP1fCQguxTtC6687mw8df9R9r1q5T1sk+at7JROZv6cWDRLwFm34JBqnpLr+/tkKbDPlyhyxnSItwjIby6vkytd1gIWulzv3uvtCZjNMfkfKMypjD/5aZfAOoCiXNs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=dm.renesas.com; Received: from OS3PR01MB6641.jpnprd01.prod.outlook.com (2603:1096:604:10b::11) by TYWPR01MB11062.jpnprd01.prod.outlook.com (2603:1096:400:396::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Tue, 17 Oct 2023 02:13:46 +0000 Received: from OS3PR01MB6641.jpnprd01.prod.outlook.com ([fe80::fb92:32d0:d0f6:a589]) by OS3PR01MB6641.jpnprd01.prod.outlook.com ([fe80::fb92:32d0:d0f6:a589%7]) with mapi id 15.20.6886.034; Tue, 17 Oct 2023 02:13:46 +0000 From: David Rau To: broonie@kernel.org Cc: support.opensource@diasemi.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, David Rau Subject: [PATCH] ASoC: da7219: Correct the process of setting up Gnd switch in AAD Date: Tue, 17 Oct 2023 10:12:58 +0800 Message-Id: <20231017021258.5929-1-David.Rau.opensource@dm.renesas.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: TYCPR01CA0203.jpnprd01.prod.outlook.com (2603:1096:405:7a::12) To OS3PR01MB6641.jpnprd01.prod.outlook.com (2603:1096:604:10b::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PR01MB6641:EE_|TYWPR01MB11062:EE_ X-MS-Office365-Filtering-Correlation-Id: 24ee7de2-1ea9-4c85-9d76-08dbceb6b1a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u1fVOlv/B9Xicmd3hprl6ATVyMmm6BGYJLfNooPXA95zkpgpH06e98cM4vcENMvZmhm2B53useZWuhT7Gtbp/z7e841s9A9gZ9TBebxFqGiLgyPbGbOHHmXtGZrzxozBsNl3sv/4cJYuusj/IgnluHuQFkdqQcryCWFRLw9HL3PgU+9PlmSdZKoFv1od5l6+C2rHCIGu+oUIDbprHwWglUCEu2gjbaqDIKr5H0LIyruhKFsCgfWoPFJyeqVDlCpmNHNpRQcB4kbPW6qnqWY8U407G4oDSkCV46jq9pqSUm9PxyNkSqi6WBVfBwWgqMbydW8RN7xPX+C2GLf+9Xwu8fuW0I1/HXMLmmNQXRJX7j4dpn/d6f/PF1QfbU71So7LXkN4+I7WGntd4LrhH0BHFs2ZVy2EAZ+pr08W/Zth2ZaMEaiZqZHisNunSWbOvhR+RjfZdkfYMX9VASU0jk701YWEHRLq8oKPR9d1vri3GEMnaSbax4K9yzDYNjEXamSZzrTl9nEFEU68TwpxGLLNTLnIJbXre7sylw/Jn0tbQ+XE+ienGjhjpXauBOeCduoof21Vtf+0aNQoXdzy94OLOW08wCHx2lciw83VeK5zi9A3k2CJ5d37PZ0TzEXvh3aS X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS3PR01MB6641.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(396003)(39860400002)(366004)(136003)(230922051799003)(186009)(64100799003)(1800799009)(451199024)(83380400001)(107886003)(316002)(1076003)(2616005)(38350700005)(26005)(103116003)(8676002)(66946007)(41300700001)(52116002)(66476007)(2906002)(8936002)(5660300002)(4326008)(6916009)(66556008)(6512007)(478600001)(6666004)(38100700002)(86362001)(6486002)(6506007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LDO0u2own5hDQHeCGQwpVJCjNMkE7y5Gvy8j9NfSqfGLZS7hxhgi5BEtdudlDNouE1muSufCGk8SUfgcvpx8e6zbEB/LPG34HQO22t3gSW8DrNc/byIb4o0U9qauNcEiQckgsXaicNv1v8A+XsPc5WlfkaTIsSXBsK9ACq2uyinZCPLZnVHvHKUx9UeTmf+j5nDy9RpmApAnr8hkm/P3UUnmQH/VS5CmE3YdAi9/qFwzEUSwQQdrcyFg/lmY4DDYVF0oLSf0DxzK4UkT33jTARJYIvXYX+mWbA7O2bneUE+EujK/w/v6BvZKdJ4tT+oOHEhJr7tNkix87t4zU9llfMyMG/c43EVcetowxH2x0yiZaUPSeEKsfCHqagNvifh9me7bbekBV+J06xgkALzuLX51Msade8gT+ALGyutDErGWPe2mIvibdFurHAoePNdnBfoyj2El05hrZM6EbMpGwXBLb8U0ozj7BXJzcN2a9D55z/6yC7eu9Qscbw1wF6XJwAFaPJik8CWOUXCOYqZoTHSQ//+E19tseQOv06byxOrpIHosmnVW+t5IFU8nc6cM5ZQvEFNW8r47gZsnRQ1d9kMQWZh/Mih23qKGU3rRJ6TQuxAn0grAjL4EmX5e1bcquxYLahCejrfrVEnSz3BIy24Py++wv3FyB7iLt4buizIx3/b/GFbg6b0kGAl8W2grTf2EZ570pXmc7NZmKTiEa8Y2kzfogbwEy3tn4UhINu+HWwLYy6uOrL2sRCqTcYz/xEx1J7vVxAZDTQ9bLw9b2Wkv66EyFLfb/8SqGNFiNOtU3UBrK5Hb9Tt0RCs9tlzypUQJMFZ5kUINJJpnV46tkeJRucRgfnS4h7bdy4rbPFeoboLZfzdQFFta2FsuAer7HIsWJmvYT+ktY7opO69NVZp2skIAulK7Z3e/e0VAEJQuwBsI92jGhTn+umnVTx+17nJnTegRdsw9jnutWG5t/ySngWYnkLhUNwdQNf09dOl/cIiMKrunfqYJcdt1inBhH7iV9ADfGLxK+aDkDvFnCbmDaETMyzJ7gaP594One0rXMtgb347X44sja/eYEpUoGb2J88N3jXYH9MWskMMtp0rjZt+L3UDL9xgqb0L0tQ+4zeULuMJEas+ZouzZgrxqIxkzdKod0cO2WDEMVxi++UGmT3rWz2j1tmxfeUmUrUgkkAaTiWa5x7QdSMu04COB8/OBXeKwdUFxgkydgODHC2jNvc7ktbmX9BHa4/hnlzrOjCGpts7jr4YdCElzHVyWHQsRC/VqBdyMEAr5boJpC7lhv3QVeY6+f9AHzoP0ChKg1x+u+b0G92E7wFO7DD2LppVVuiDgWxoAKKpe5XMk71U3MCZYbr/EUe0hQt0HeePN6aE3pH63DwZ6Gqx5aXGRBnQe0H4cF0ws1K6IyBRVfXgE5jsBo696kmvk7FeMwFiG8DVOaVeAjN36VsDy1WMsjODad/qeQBd5NJRtxbGRwY4qE4/0jVcnI1llPeduCQJ2mCta+gzTlWsBo8LkFxNP8GN3FdJYbfiQc93A6Id9D3kxkBxy4CFewhzIX1aJp73zgwS3e+X7+XkYsivAO/LltN+PFNSHEzJUnbXVLF6yvQ== X-OriginatorOrg: dm.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24ee7de2-1ea9-4c85-9d76-08dbceb6b1a5 X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB6641.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 02:13:46.4291 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QHO3dVPH36JvZ/dZ9MIDWlT21uImj6YSexf8RMjOpABWkHa0ji5h0obsGjpJDRDbsdOhAukIuc1iP2CwPGyLYJ8vPLO7+NtdfXSrVvzVy3E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB11062 Message-ID-Hash: UDRWC5HBNMOHMOGYXVWIWSHHIUFTI7K3 X-Message-ID-Hash: UDRWC5HBNMOHMOGYXVWIWSHHIUFTI7K3 X-MailFrom: David.Rau.opensource@dm.renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Enable Gnd switch to improve stability when Jack insert event occurs, and then disable Gnd switch after Jack type detection is finished. Signed-off-by: David Rau --- sound/soc/codecs/da7219-aad.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/da7219-aad.c b/sound/soc/codecs/da7219-aad.c index 581b334a6631..3bbe85091649 100644 --- a/sound/soc/codecs/da7219-aad.c +++ b/sound/soc/codecs/da7219-aad.c @@ -59,9 +59,6 @@ static void da7219_aad_btn_det_work(struct work_struct *work) bool micbias_up = false; int retries = 0; - /* Disable ground switch */ - snd_soc_component_update_bits(component, 0xFB, 0x01, 0x00); - /* Drive headphones/lineout */ snd_soc_component_update_bits(component, DA7219_HP_L_CTRL, DA7219_HP_L_AMP_OE_MASK, @@ -155,9 +152,6 @@ static void da7219_aad_hptest_work(struct work_struct *work) tonegen_freq_hptest = cpu_to_le16(DA7219_AAD_HPTEST_RAMP_FREQ_INT_OSC); } - /* Disable ground switch */ - snd_soc_component_update_bits(component, 0xFB, 0x01, 0x00); - /* Ensure gain ramping at fastest rate */ gain_ramp_ctrl = snd_soc_component_read(component, DA7219_GAIN_RAMP_CTRL); snd_soc_component_write(component, DA7219_GAIN_RAMP_CTRL, DA7219_GAIN_RAMP_RATE_X8); @@ -421,6 +415,11 @@ static irqreturn_t da7219_aad_irq_thread(int irq, void *data) * handle a removal, and we can check at the end of * hptest if we have a valid result or not. */ + + cancel_delayed_work_sync(&da7219_aad->jack_det_work); + /* Disable ground switch */ + snd_soc_component_update_bits(component, 0xFB, 0x01, 0x00); + if (statusa & DA7219_JACK_TYPE_STS_MASK) { report |= SND_JACK_HEADSET; mask |= SND_JACK_HEADSET | SND_JACK_LINEOUT;