diff mbox series

ASoC: Intel: Skylake: add an error code check in skl_pcm_trigger

Message ID 20231020092619.210520-1-suhui@nfschina.com (mailing list archive)
State Accepted
Commit f5c7bc7a1fad4e1e8d3d29d71dd9f430a3350f42
Headers show
Series ASoC: Intel: Skylake: add an error code check in skl_pcm_trigger | expand

Commit Message

Su Hui Oct. 20, 2023, 9:26 a.m. UTC
skl_decoupled_trigger() can return error code like -EPIPE if failed,
add check for this.

Signed-off-by: Su Hui <suhui@nfschina.com>
---
 sound/soc/intel/skylake/skl-pcm.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Mark Brown Oct. 26, 2023, 3:12 p.m. UTC | #1
On Fri, 20 Oct 2023 17:26:20 +0800, Su Hui wrote:
> skl_decoupled_trigger() can return error code like -EPIPE if failed,
> add check for this.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: Skylake: add an error code check in skl_pcm_trigger
      commit: f5c7bc7a1fad4e1e8d3d29d71dd9f430a3350f42

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
index ac3dc8c63c26..40308501f8bf 100644
--- a/sound/soc/intel/skylake/skl-pcm.c
+++ b/sound/soc/intel/skylake/skl-pcm.c
@@ -518,6 +518,9 @@  static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
 			return ret;
 
 		ret = skl_decoupled_trigger(substream, cmd);
+		if (ret < 0)
+			return ret;
+
 		if ((cmd == SNDRV_PCM_TRIGGER_SUSPEND) && !w->ignore_suspend) {
 			/* save the dpib and lpib positions */
 			hstream->dpib = readl(bus->remap_addr +