From patchwork Wed Nov 8 10:43:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13449710 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B38DC0018C for ; Wed, 8 Nov 2023 10:46:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344578AbjKHKqe (ORCPT ); Wed, 8 Nov 2023 05:46:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344566AbjKHKpr (ORCPT ); Wed, 8 Nov 2023 05:45:47 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99AA52712 for ; Wed, 8 Nov 2023 02:44:41 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2c50ec238aeso92615731fa.0 for ; Wed, 08 Nov 2023 02:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440280; x=1700045080; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eLncO1ADQq/KYbPV1LBS+813XGTk7ajEpj3gEwbCXmE=; b=at7bnm2pLlm5m3ryH1cZRMIBYRJsXleRtjdxXHIuAoQQ4dLJMJvD7NzdTRUY4tsE7P b+rsF1rKqsOmcbxiKTQgRSxqh4PwTSfeTPWRRbZL6gxV/MwgKGDh4NGoC5OqgQdZtYU6 bOQv7yHWOf826XXuROFe+hP7HQUf+1QhB9L80g0bMtp0xjc1IvALy1LcqedRaNfYSJnM OUqLAGa2A5tylU7m4VGED8i/3qOooqLzxE9u6UpT/g6le91eMNypn+VKp0DxiC4cCJS7 X+rjmE8yFtGnid92WZ6xFN7i/3jv5IyEf/aMQ0/yHDxRxJy56+KAtHOm0X56PdKSgXFT EGbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440280; x=1700045080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eLncO1ADQq/KYbPV1LBS+813XGTk7ajEpj3gEwbCXmE=; b=Wrt+cTqwbQQRDHTubWOATmQr2HGqnFB5cB5mULWK7j/noSaFFTVv1ApB31gGyAVfCH OKm1yhGXHA/vvbCLLysNF8yFcRnjwTfVH8bTGuTumXWTSR2X/OPR+uFhruUgAX81myOV URJHCPRNwEmGRfHlVOD7AwXrdjh5g8reY4jTiGZVbJgsAwRe39s+IepNJceikm0XvNWd Sk5UaU43LFEV4S3bZ4bFR9scrNkN1vcQOq8zw9TSWBjb0ShHcWCUcCeg/6IEQ2cKknto GeDlZT7TGmHK5Pohsg/c8CjUNYWagqTokw0sWsnQ6/Z0Tbo2VEeSCqW6zIF6lqAIoL1u KGYw== X-Gm-Message-State: AOJu0YyRcGheY8wb0UEK1Vk5pFO45JKJ7Cdrq+SbMmZB9UwdS7t0tXVo pk6kD5et2xcAeBbKdDqRF1FW5g== X-Google-Smtp-Source: AGHT+IE9e7WdZJcWzB5Gf22P43YL/3qsWhZ9UWDtVmtmQ2zCC7QEZqOnQRFgEbbvc33FYHTz/Q1w1g== X-Received: by 2002:a2e:81a:0:b0:2c5:7afd:75a1 with SMTP id 26-20020a2e081a000000b002c57afd75a1mr1229802lji.44.1699440279685; Wed, 08 Nov 2023 02:44:39 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:39 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 12/17] dt-bindings: pwm: samsung: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:38 +0100 Message-Id: <20231108104343.24192-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-sound@vger.kernel.org Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Uwe Kleine-König Acked-by: Rob Herring Reviewed-by: Alim Akhtar --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml index 2162f661ed5a..89a3875cb50a 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml @@ -29,6 +29,8 @@ properties: - samsung,exynos4210-pwm # 32-bit, Exynos - items: - enum: + - samsung,exynos5433-pwm + - samsung,exynos7-pwm - samsung,exynosautov9-pwm - const: samsung,exynos4210-pwm