| Message ID | 20231120084227.1766633-1-CTLIN0@nuvoton.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | af524e9dcb43f5914cecb3a3f4b79081d2e3f7f8 |
| Headers | show |
| Series | ASoC: nau8810: Fix incorrect type in assignment and cast to restricted __be16 | expand |
On Mon, 20 Nov 2023 16:42:28 +0800, David Lin wrote: > This issue is reproduced when W=1 build in compiler gcc-12. > The following are sparse warnings: > > sound/soc/codecs/nau8810.c:183:25: sparse: warning: incorrect type in assignment > sound/soc/codecs/nau8810.c:183:25: sparse: expected int > sound/soc/codecs/nau8810.c:183:25: sparse: got restricted __be16 > sound/soc/codecs/nau8810.c:219:25: sparse: warning: cast to restricted __be16 > sound/soc/codecs/nau8810.c:219:25: sparse: warning: cast to restricted __be16 > sound/soc/codecs/nau8810.c:219:25: sparse: warning: cast to restricted __be16 > sound/soc/codecs/nau8810.c:219:25: sparse: warning: cast to restricted __be16 > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: nau8810: Fix incorrect type in assignment and cast to restricted __be16 commit: af524e9dcb43f5914cecb3a3f4b79081d2e3f7f8 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/nau8810.c b/sound/soc/codecs/nau8810.c index 47f000cd4d99..97a54059474c 100644 --- a/sound/soc/codecs/nau8810.c +++ b/sound/soc/codecs/nau8810.c @@ -169,6 +169,7 @@ static int nau8810_eq_get(struct snd_kcontrol *kcontrol, struct soc_bytes_ext *params = (void *)kcontrol->private_value; int i, reg, reg_val; u16 *val; + __be16 tmp; val = (u16 *)ucontrol->value.bytes.data; reg = NAU8810_REG_EQ1; @@ -177,8 +178,8 @@ static int nau8810_eq_get(struct snd_kcontrol *kcontrol, /* conversion of 16-bit integers between native CPU format * and big endian format */ - reg_val = cpu_to_be16(reg_val); - memcpy(val + i, ®_val, sizeof(reg_val)); + tmp = cpu_to_be16(reg_val); + memcpy(val + i, &tmp, sizeof(tmp)); } return 0; @@ -201,6 +202,7 @@ static int nau8810_eq_put(struct snd_kcontrol *kcontrol, void *data; u16 *val, value; int i, reg, ret; + __be16 *tmp; data = kmemdup(ucontrol->value.bytes.data, params->max, GFP_KERNEL | GFP_DMA); @@ -213,7 +215,8 @@ static int nau8810_eq_put(struct snd_kcontrol *kcontrol, /* conversion of 16-bit integers between native CPU format * and big endian format */ - value = be16_to_cpu(*(val + i)); + tmp = (__be16 *)(val + i); + value = be16_to_cpup(tmp); ret = regmap_write(nau8810->regmap, reg + i, value); if (ret) { dev_err(component->dev, "EQ configuration fail, register: %x ret: %d\n",
This issue is reproduced when W=1 build in compiler gcc-12. The following are sparse warnings: sound/soc/codecs/nau8810.c:183:25: sparse: warning: incorrect type in assignment sound/soc/codecs/nau8810.c:183:25: sparse: expected int sound/soc/codecs/nau8810.c:183:25: sparse: got restricted __be16 sound/soc/codecs/nau8810.c:219:25: sparse: warning: cast to restricted __be16 sound/soc/codecs/nau8810.c:219:25: sparse: warning: cast to restricted __be16 sound/soc/codecs/nau8810.c:219:25: sparse: warning: cast to restricted __be16 sound/soc/codecs/nau8810.c:219:25: sparse: warning: cast to restricted __be16 This issue is not still actively checked by kernel test robot. Actually, it is same with nau8822's sparse warnings issue. Signed-off-by: David Lin <CTLIN0@nuvoton.com> --- sound/soc/codecs/nau8810.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)